Merge branch 'qa-no-monkey-patching-1_manage' into 'master'

Update 1_manage tests to use outer describe

See merge request gitlab-org/gitlab!35635

qa/qa/specs/features/api/1_manage/rate_limits_spec.rb

@@ -3,7 +3,7 @@
 require 'airborne'
 
 module QA
-  context 'Manage with IP rate limits', :requires_admin do
+  RSpec.describe 'Manage with IP rate limits', :requires_admin do
     describe 'Users API' do
       let(:api_client) { Runtime::API::Client.new(:gitlab, ip_limits: true) }
       let(:request) { Runtime::API::Request.new(api_client, '/users') }

qa/qa/specs/features/api/1_manage/users_spec.rb

@@ -3,7 +3,7 @@
 require 'airborne'
 
 module QA
-  context 'Manage' do
+  RSpec.describe 'Manage' do
     describe 'Users API' do
       before(:context) do
         @api_client = Runtime::API::Client.new(:gitlab)

qa/qa/specs/features/browser_ui/1_manage/group/create_group_with_mattermost_team_spec.rb

 # frozen_string_literal: true
 
 module QA
-  context 'Configure', :orchestrated, :mattermost do
+  RSpec.describe 'Configure', :orchestrated, :mattermost do
     describe 'Mattermost support' do
       it 'user creates a group with a mattermost team' do
         Flow::Login.sign_in

qa/qa/specs/features/browser_ui/1_manage/group/transfer_project_spec.rb

 # frozen_string_literal: true
 
 module QA
-  context 'Manage' do
+  RSpec.describe 'Manage' do
     describe 'Project transfer between groups' do
       it 'user transfers a project between groups' do
         Flow::Login.sign_in

qa/qa/specs/features/browser_ui/1_manage/login/log_in_spec.rb

 # frozen_string_literal: true
 
 module QA
-  context 'Manage', :smoke do
+  RSpec.describe 'Manage', :smoke do
     describe 'basic user login' do
       it 'user logs in using basic credentials and logs out' do
         Flow::Login.sign_in

qa/qa/specs/features/browser_ui/1_manage/login/log_into_gitlab_via_ldap_spec.rb

 # frozen_string_literal: true
 
 module QA
-  context 'Manage', :orchestrated, :ldap_no_tls, :ldap_tls do
+  RSpec.describe 'Manage', :orchestrated, :ldap_no_tls, :ldap_tls do
     describe 'LDAP login' do
       it 'user logs into GitLab using LDAP credentials' do
         Flow::Login.sign_in

qa/qa/specs/features/browser_ui/1_manage/login/log_into_mattermost_via_gitlab_spec.rb

 # frozen_string_literal: true
 
 module QA
-  context 'Manage', :orchestrated, :mattermost do
+  RSpec.describe 'Manage', :orchestrated, :mattermost do
     describe 'Mattermost login' do
       it 'user logs into Mattermost using GitLab OAuth' do
         Flow::Login.sign_in

qa/qa/specs/features/browser_ui/1_manage/login/login_via_instance_wide_saml_sso_spec.rb

 # frozen_string_literal: true
 
 module QA
-  context 'Manage', :orchestrated, :instance_saml do
+  RSpec.describe 'Manage', :orchestrated, :instance_saml do
     describe 'Instance wide SAML SSO' do
       it 'User logs in to gitlab with SAML SSO' do
         Runtime::Browser.visit(:gitlab, Page::Main::Login)

qa/qa/specs/features/browser_ui/1_manage/login/register_spec.rb

 # frozen_string_literal: true
 
 module QA
-  shared_examples 'registration and login' do
+  RSpec.shared_examples 'registration and login' do
     it 'user registers and logs in' do
       Runtime::Browser.visit(:gitlab, Page::Main::Login)
 
@@ -13,13 +13,13 @@ module QA
     end
   end
 
-  context 'Manage', :skip_signup_disabled do
+  RSpec.describe 'Manage', :skip_signup_disabled do
     describe 'standard' do
       it_behaves_like 'registration and login'
     end
   end
 
-  context 'Manage', :orchestrated, :ldap_no_tls, :skip_signup_disabled do
+  RSpec.describe 'Manage', :orchestrated, :ldap_no_tls, :skip_signup_disabled do
     describe 'while LDAP is enabled' do
       it_behaves_like 'registration and login'
     end

qa/qa/specs/features/browser_ui/1_manage/project/add_project_member_spec.rb

 # frozen_string_literal: true
 
 module QA
-  context 'Manage' do
+  RSpec.describe 'Manage' do
     describe 'Add project member' do
       it 'user adds project member' do
         Flow::Login.sign_in

qa/qa/specs/features/browser_ui/1_manage/project/create_project_spec.rb

 # frozen_string_literal: true
 
 module QA
-  context 'Manage', :smoke do
+  RSpec.describe 'Manage', :smoke do
     describe 'Project creation' do
       it 'user creates a new project' do
         Flow::Login.sign_in

qa/qa/specs/features/browser_ui/1_manage/project/dashboard_images_spec.rb

@@ -3,7 +3,7 @@
 require 'nokogiri'
 
 module QA
-  context 'Manage', quarantine: { issue: 'https://gitlab.com/gitlab-org/gitlab/-/issues/212145', type: :stale } do
+  RSpec.describe 'Manage', quarantine: { issue: 'https://gitlab.com/gitlab-org/gitlab/-/issues/212145', type: :stale } do
     describe 'Check for broken images', :requires_admin do
       before(:context) do
         admin = QA::Resource::User.new.tap do |user|

qa/qa/specs/features/browser_ui/1_manage/project/import_github_repo_spec.rb

 # frozen_string_literal: true
 
 module QA
-  context 'Manage', :github, quarantine: { issue: 'https://gitlab.com/gitlab-org/gitlab/issues/26952', type: :bug } do
+  RSpec.describe 'Manage', :github, quarantine: { issue: 'https://gitlab.com/gitlab-org/gitlab/issues/26952', type: :bug } do
     describe 'Project import from GitHub' do
       let(:imported_project) do
         Resource::ProjectImportedFromGithub.fabricate! do |project|

qa/qa/specs/features/browser_ui/1_manage/project/protected_tags_spec.rb

 # frozen_string_literal: true
 
 module QA
-  context 'Manage' do
+  RSpec.describe 'Manage' do
     describe 'Repository tags' do
       let(:project) do
         Resource::Project.fabricate_via_api! do |project|

qa/qa/specs/features/browser_ui/1_manage/project/view_project_activity_spec.rb

 # frozen_string_literal: true
 
 module QA
-  context 'Manage' do
+  RSpec.describe 'Manage' do
     describe 'Project activity' do
       it 'user creates an event in the activity page upon Git push' do
         Flow::Login.sign_in

qa/qa/specs/features/ee/browser_ui/1_manage/group/group_audit_logs_1_spec.rb

@@ -2,7 +2,7 @@
 require 'securerandom'
 
 module QA
-  context 'Manage' do
+  RSpec.describe 'Manage' do
     include Support::Api
 
     let(:api_client) { Runtime::API::Client.new(:gitlab) }

qa/qa/specs/features/ee/browser_ui/1_manage/group/group_audit_logs_2_spec.rb

@@ -2,7 +2,7 @@
 require 'securerandom'
 
 module QA
-  context 'Manage' do
+  RSpec.describe 'Manage' do
     shared_examples 'audit event' do |expected_events|
       it 'logs audit events for UI operations' do
         Page::Group::Menu.perform(&:go_to_audit_events_settings)

qa/qa/specs/features/ee/browser_ui/1_manage/group/group_file_template_spec.rb

 # frozen_string_literal: true
 
 module QA
-  context 'Manage' do
+  RSpec.describe 'Manage' do
     describe 'Group file templates', :requires_admin do
       include Support::Api
 

qa/qa/specs/features/ee/browser_ui/1_manage/group/group_ldap_sync_spec.rb

 # frozen_string_literal: true
 
 module QA
-  context 'Manage', :orchestrated, :ldap_tls, :ldap_no_tls, :requires_admin do
+  RSpec.describe 'Manage', :orchestrated, :ldap_tls, :ldap_no_tls, :requires_admin do
     describe 'LDAP Group sync' do
       include Support::Api
 

qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_enforced_sso_spec.rb

 # frozen_string_literal: true
 
 module QA
-  context 'Manage', :group_saml, :orchestrated do
+  RSpec.describe 'Manage', :group_saml, :orchestrated do
     describe 'Group SAML SSO - Enforced SSO' do
       include Support::Api
 

qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_group_managed_accounts_spec.rb

 # frozen_string_literal: true
 
 module QA
-  context 'Manage', :group_saml, :orchestrated, :requires_admin, quarantine: { issue: 'https://gitlab.com/gitlab-org/gitlab/issues/202260', type: :bug } do
+  RSpec.describe 'Manage', :group_saml, :orchestrated, :requires_admin, quarantine: { issue: 'https://gitlab.com/gitlab-org/gitlab/issues/202260', type: :bug } do
     describe 'Group SAML SSO - Group managed accounts' do
       include Support::Api
 

qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_non_enforced_sso_spec.rb

 # frozen_string_literal: true
 
 module QA
-  context 'Manage', :group_saml, :orchestrated, :requires_admin do
+  RSpec.describe 'Manage', :group_saml, :orchestrated, :requires_admin do
     describe 'Group SAML SSO - Non enforced SSO' do
       include Support::Api
 

qa/qa/specs/features/ee/browser_ui/1_manage/group/restrict_by_ip_address_spec.rb

@@ -2,7 +2,7 @@
 require 'securerandom'
 
 module QA
-  context 'Manage' do
+  RSpec.describe 'Manage' do
     describe 'Group access', :requires_admin, :skip_live_env do
       include Runtime::IPAddress
 

qa/qa/specs/features/ee/browser_ui/1_manage/insights/default_insights_spec.rb

 # frozen_string_literal: true
 
 module QA
-  context 'Manage' do
+  RSpec.describe 'Manage' do
     shared_examples 'default insights page' do
       it 'displays issues and merge requests dashboards' do
         EE::Page::Insights::Show.perform do |show|

qa/qa/specs/features/ee/browser_ui/1_manage/instance/instance_audit_logs_spec.rb

@@ -2,7 +2,7 @@
 require 'securerandom'
 
 module QA
-  context 'Manage', quarantine: { issue: 'https://gitlab.com/gitlab-org/gitlab/-/issues/218332', type: :investigating } do
+  RSpec.describe 'Manage', quarantine: { issue: 'https://gitlab.com/gitlab-org/gitlab/-/issues/218332', type: :investigating } do
     shared_examples 'audit event' do |expected_events|
       it 'logs audit events for UI operations' do
         sign_in

qa/qa/specs/features/ee/browser_ui/1_manage/ldap/admin_ldap_sync_spec.rb

 # frozen_string_literal: true
 module QA
-  context 'Manage', :orchestrated, :ldap_no_server do
+  RSpec.describe 'Manage', :orchestrated, :ldap_no_server do
     describe 'LDAP admin sync' do
       before do
         run_ldap_service_with_user_as('admin')

qa/qa/specs/features/ee/browser_ui/1_manage/project/project_audit_logs_spec.rb

 # frozen_string_literal: true
 
 module QA
-  context 'Manage' do
+  RSpec.describe 'Manage' do
     shared_examples 'audit event' do |expected_events|
       it 'logs audit events for UI operations' do
         Page::Project::Menu.perform(&:go_to_audit_events_settings)

qa/qa/specs/features/ee/browser_ui/1_manage/project/project_templates_spec.rb

@@ -2,7 +2,7 @@
 require 'securerandom'
 
 module QA
-  context :manage do
+  RSpec.describe 'Manage' do
     describe 'Project templates' do
       before(:all) do
         @files = [