Commit 21bf833f authored by Robert Speicher's avatar Robert Speicher

Merge branch 'bw-review-feedback-task-list-toggle-service' into 'master'

Address review comment for app/services/task_list_toggle_service.rb

Closes #57413

See merge request gitlab-org/gitlab-ce!25013
parents a1215556 01835ef0
...@@ -33,7 +33,7 @@ class TaskListToggleService ...@@ -33,7 +33,7 @@ class TaskListToggleService
markdown_task = source_lines[source_line_index] markdown_task = source_lines[source_line_index]
# The source in the DB could be using either \n or \r\n line endings # The source in the DB could be using either \n or \r\n line endings
return unless markdown_task == line_source || markdown_task == line_source + "\r" return unless markdown_task.chomp == line_source
return unless source_checkbox = Taskable::ITEM_PATTERN.match(markdown_task) return unless source_checkbox = Taskable::ITEM_PATTERN.match(markdown_task)
currently_checked = TaskList::Item.new(source_checkbox[1]).complete? currently_checked = TaskList::Item.new(source_checkbox[1]).complete?
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment