Merge branch 'pin-auto-devops-dind-version' into 'master'

Pin Auto DevOps dind version to fix pull timeout

See merge request gitlab-org/gitlab!25286

changelogs/unreleased/pin-auto-devops-dind-version.yml

+---
+title: Pin Auto DevOps Docker-in-Docker service image to work around pull timeouts
+merge_request: 25286
+author:
+type: fixed

lib/gitlab/ci/templates/Jobs/Browser-Performance-Testing.gitlab-ci.yml

 performance:
   stage: performance
-  image: docker:stable
+  # pin to a version matching the dind service, just to be safe
+  image: docker:19.03.5
   allow_failure: true
   variables:
     DOCKER_TLS_CERTDIR: ""
   services:
-    - docker:stable-dind
+    # pin to a known working version until https://gitlab.com/gitlab-org/gitlab-runner/issues/6697 is fixed
+    - docker:19.03.5-dind
   script:
     - |
       if ! docker info &>/dev/null; then

lib/gitlab/ci/templates/Jobs/Build.gitlab-ci.yml

@@ -4,7 +4,8 @@ build:
   variables:
     DOCKER_TLS_CERTDIR: ""
   services:
-    - docker:stable-dind
+    # pin to a known working version until https://gitlab.com/gitlab-org/gitlab-runner/issues/6697 is fixed
+    - docker:19.03.5-dind
   script:
     - |
       if [[ -z "$CI_COMMIT_TAG" ]]; then

lib/gitlab/ci/templates/Jobs/Code-Quality.gitlab-ci.yml

 code_quality:
   stage: test
-  image: docker:stable
+  # pin to a version matching the dind service, just to be safe
+  image: docker:19.03.5
   allow_failure: true
   services:
-    - docker:stable-dind
+    # pin to a known working version until https://gitlab.com/gitlab-org/gitlab-runner/issues/6697 is fixed
+    - docker:19.03.5-dind
   variables:
     DOCKER_DRIVER: overlay2
     DOCKER_TLS_CERTDIR: ""