Reduce the difference between CE and EE for upload and LFS object checks

ee/lib/tasks/gitlab/uploads/check.rake

-require_relative 'helpers.rb'
-
-namespace :gitlab do
-  namespace :uploads do
-    desc 'GitLab | Uploads | Check integrity of uploaded files'
-    task check: :environment do
-      include UploadTaskHelpers
-
-      puts 'Checking integrity of uploaded files'
-
-      uploads_batches do |batch|
-        batch.each do |upload|
-          begin
-            puts "- Checking file (#{upload.id}): #{upload.absolute_path}".color(:green)
-
-            if upload.exist?
-              check_checksum(upload)
-            else
-              puts "  * File does not exist on the file system".color(:red)
-            end
-          rescue ObjectStorage::RemoteStoreError
-            puts "- File (#{upload.id}): File is stored remotely, skipping".color(:yellow)
-          end
-        end
-      end
-
-      puts 'Done!'
-    end
-  end
-end

ee/lib/tasks/gitlab/uploads/helpers.rb

-module UploadTaskHelpers
-  def batch_size
-    ENV.fetch('BATCH', 200).to_i
-  end
-
-  def calculate_checksum(absolute_path)
-    Digest::SHA256.file(absolute_path).hexdigest
-  end
-
-  def check_checksum(upload)
-    checksum = calculate_checksum(upload.absolute_path)
-
-    if checksum != upload.checksum
-      puts "  * File checksum (#{checksum}) does not match the one in the database (#{upload.checksum})".color(:red)
-    end
-  end
-
-  def uploads_batches(&block)
-    Upload.all.in_batches(of: batch_size, start: ENV['ID_FROM'], finish: ENV['ID_TO']) do |relation| # rubocop: disable Cop/InBatches
-      yield relation
-    end
-  end
-end

ee/spec/tasks/gitlab/lfs_rake_spec.rb → ee/spec/tasks/gitlab/lfs/migrate_rake_spec.rb

@@ -2,7 +2,7 @@ require 'rake_helper'
 
 describe 'gitlab:lfs namespace rake task' do
   before :all do
-    Rake.application.rake_require 'tasks/gitlab/lfs'
+    Rake.application.rake_require 'tasks/gitlab/lfs/migrate'
   end
 
   describe 'migrate' do

ee/spec/tasks/gitlab/uploads/check_rake_spec.rb

-require 'rake_helper'
-
-describe 'gitlab:uploads:check rake tasks' do
-  let!(:upload) { create(:upload, path: Rails.root.join('spec/fixtures/banana_sample.gif')) }
-
-  before do
-    Rake.application.rake_require 'tasks/gitlab/uploads/check'
-  end
-
-  it 'outputs the integrity check for each uploaded file' do
-    expect { run_rake_task('gitlab:uploads:check') }.to output(/Checking file \(#{upload.id}\): #{Regexp.quote(upload.absolute_path)}/).to_stdout
-  end
-
-  it 'errors out about missing files on the file system' do
-    create(:upload)
-
-    expect { run_rake_task('gitlab:uploads:check') }.to output(/File does not exist on the file system/).to_stdout
-  end
-
-  it 'errors out about invalid checksum' do
-    upload.update_column(:checksum, '01a3156db2cf4f67ec823680b40b7302f89ab39179124ad219f94919b8a1769e')
-
-    expect { run_rake_task('gitlab:uploads:check') }.to output(/File checksum \(9e697aa09fe196909813ee36103e34f721fe47a5fdc8aac0e4e4ac47b9b38282\) does not match the one in the database \(#{upload.checksum}\)/).to_stdout
-  end
-end