Commit 23f7f15f authored by Stan Hu's avatar Stan Hu

Merge branch 'dstull-fix-around-travel-to' into 'master'

Fix tests being skipped due to around hook

See merge request gitlab-org/gitlab!59052
parents db595ee0 243a6689
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
module Groups module Groups
module GroupLinks module GroupLinks
class CreateService < BaseService class CreateService < Groups::BaseService
def execute(shared_group) def execute(shared_group)
unless group && shared_group && unless group && shared_group &&
can?(current_user, :admin_group_member, shared_group) && can?(current_user, :admin_group_member, shared_group) &&
......
...@@ -9,16 +9,17 @@ RSpec.describe Groups::GroupLinksController do ...@@ -9,16 +9,17 @@ RSpec.describe Groups::GroupLinksController do
let(:group_member) { create(:user) } let(:group_member) { create(:user) }
let!(:project) { create(:project, group: shared_group) } let!(:project) { create(:project, group: shared_group) }
around do |example|
travel_to DateTime.new(2019, 4, 1) { example.run }
end
before do before do
travel_to DateTime.new(2019, 4, 1)
sign_in(user) sign_in(user)
shared_with_group.add_developer(group_member) shared_with_group.add_developer(group_member)
end end
after do
travel_back
end
shared_examples 'placeholder is passed as `id` parameter' do |action| shared_examples 'placeholder is passed as `id` parameter' do |action|
it 'returns a 404' do it 'returns a 404' do
post( post(
......
...@@ -9,8 +9,12 @@ RSpec.describe Groups::GroupMembersController do ...@@ -9,8 +9,12 @@ RSpec.describe Groups::GroupMembersController do
let(:group) { create(:group, :public) } let(:group) { create(:group, :public) }
let(:membership) { create(:group_member, group: group) } let(:membership) { create(:group_member, group: group) }
around do |example| before do
travel_to DateTime.new(2019, 4, 1) { example.run } travel_to DateTime.new(2019, 4, 1)
end
after do
travel_back
end end
describe 'GET index' do describe 'GET index' do
......
...@@ -8,15 +8,16 @@ RSpec.describe Projects::GroupLinksController do ...@@ -8,15 +8,16 @@ RSpec.describe Projects::GroupLinksController do
let_it_be(:project) { create(:project, :private, group: group2) } let_it_be(:project) { create(:project, :private, group: group2) }
let_it_be(:user) { create(:user) } let_it_be(:user) { create(:user) }
around do |example|
travel_to DateTime.new(2019, 4, 1) { example.run }
end
before do before do
travel_to DateTime.new(2019, 4, 1)
project.add_maintainer(user) project.add_maintainer(user)
sign_in(user) sign_in(user)
end end
after do
travel_back
end
describe '#create' do describe '#create' do
shared_context 'link project to group' do shared_context 'link project to group' do
before do before do
......
...@@ -7,8 +7,12 @@ RSpec.describe Projects::ProjectMembersController do ...@@ -7,8 +7,12 @@ RSpec.describe Projects::ProjectMembersController do
let(:group) { create(:group, :public) } let(:group) { create(:group, :public) }
let(:project) { create(:project, :public) } let(:project) { create(:project, :public) }
around do |example| before do
travel_to DateTime.new(2019, 4, 1) { example.run } travel_to DateTime.new(2019, 4, 1)
end
after do
travel_back
end end
describe 'GET index' do describe 'GET index' do
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment