Merge branch '339816-dont-detect-issues-in-factories' into 'master'

Ignore FactoryBot #create for cross-database modification detection

See merge request gitlab-org/gitlab!72941

spec/support/database/prevent_cross_database_modification.rb

@@ -61,6 +61,7 @@ module Database
       return unless cross_database_context[:enabled]
 
       return if connection.pool.instance_of?(ActiveRecord::ConnectionAdapters::NullPool)
+      return if in_factory_bot_create?
 
       database = connection.pool.db_config.name
 
@@ -113,6 +114,15 @@ module Database
         raise Database::PreventCrossDatabaseModification::CrossDatabaseModificationAcrossUnsupportedTablesError, message
       end
     end
+
+    # We ignore execution in the #create method from FactoryBot
+    # because it is not representative of real code we run in
+    # production. There are far too many false positives caused
+    # by instantiating objects in different `gitlab_schema` in a
+    # FactoryBot `create`.
+    def self.in_factory_bot_create?
+      caller_locations.any? { |l| l.path.end_with?('lib/factory_bot/evaluation.rb') && l.label == 'create' }
+    end
   end
 end
 

spec/support_specs/database/prevent_cross_database_modification_spec.rb

@@ -127,6 +127,14 @@ RSpec.describe 'Database::PreventCrossDatabaseModification' do
               expect { run_queries }.to raise_error /Cross-database data modification/
             end
           end
+
+          context 'when the modification is inside a factory save! call' do
+            let(:runner) { create(:ci_runner, :project, projects: [build(:project)]) }
+
+            it 'does not raise an error' do
+              runner
+            end
+          end
         end
       end
     end
@@ -152,14 +160,6 @@ RSpec.describe 'Database::PreventCrossDatabaseModification' do
         end.not_to raise_error
       end
 
-      it 'raises error when complex factories are built referencing both databases' do
-        expect do
-          ApplicationRecord.transaction do
-            create(:ci_pipeline)
-          end
-        end.to raise_error /Cross-database data modification/
-      end
-
       it 'skips raising error on factory creation' do
         expect do
           Gitlab::Database.allow_cross_database_modification_within_transaction(url: 'gitlab-issue') do