Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
24f7e157
Commit
24f7e157
authored
Oct 08, 2020
by
Tiffany Rea
Committed by
Mark Lapierre
Oct 08, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix CI Variable spec
Add wait after adding variable Remove extra expanding session action
parent
b2ee2fd6
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
15 additions
and
20 deletions
+15
-20
qa/qa/page/project/settings/ci_variables.rb
qa/qa/page/project/settings/ci_variables.rb
+4
-0
qa/qa/specs/features/browser_ui/4_verify/ci_variable/add_remove_ci_variable_spec.rb
...er_ui/4_verify/ci_variable/add_remove_ci_variable_spec.rb
+11
-20
No files found.
qa/qa/page/project/settings/ci_variables.rb
View file @
24f7e157
...
...
@@ -26,6 +26,10 @@ module QA
within_element
(
:ci_variable_key_field
)
{
find
(
'input'
).
set
key
}
fill_element
:ci_variable_value_field
,
value
click_ci_variable_save_button
wait_until
(
reload:
false
)
do
within_element
(
:ci_variable_table_content
)
{
has_element?
(
:edit_ci_variable_button
)
}
end
end
def
click_add_variable
...
...
qa/qa/specs/features/browser_ui/4_verify/ci_variable/add_remove_ci_variable_spec.rb
View file @
24f7e157
...
...
@@ -3,7 +3,7 @@
module
QA
RSpec
.
describe
'Verify'
do
describe
'Add or Remove CI variable via UI'
,
:smoke
do
let
!
(
:project
)
do
let
(
:project
)
do
Resource
::
Project
.
fabricate_via_api!
do
|
project
|
project
.
name
=
'project-with-ci-variables'
project
.
description
=
'project with CI variables'
...
...
@@ -12,31 +12,27 @@ module QA
before
do
Flow
::
Login
.
sign_in
project
.
visit!
add_ci_variable
open_ci_cd_settings
end
it
'user adds a CI variable'
,
testcase:
'https://gitlab.com/gitlab-org/quality/testcases/-/issues/395'
do
Page
::
Project
::
Settings
::
CICD
.
perform
do
|
settings
|
settings
.
expand_ci_variables
do
|
page
|
expect
(
page
).
to
have_text
(
'VARIABLE_KEY'
)
expect
(
page
).
not_to
have_text
(
'some_CI_variable'
)
Page
::
Project
::
Settings
::
CiVariables
.
perform
do
|
ci_variable
|
expect
(
ci_variable
).
to
have_text
(
'VARIABLE_KEY'
)
expect
(
ci_variable
).
to
have_no_text
(
'some_CI_variable'
)
pag
e
.
click_reveal_ci_variable_value_button
ci_variabl
e
.
click_reveal_ci_variable_value_button
expect
(
page
).
to
have_text
(
'some_CI_variable'
)
end
expect
(
ci_variable
).
to
have_text
(
'some_CI_variable'
)
end
end
it
'user removes a CI variable'
,
testcase:
'https://gitlab.com/gitlab-org/quality/testcases/-/issues/394'
do
Page
::
Project
::
Settings
::
CICD
.
perform
do
|
settings
|
settings
.
expand_ci_variables
do
|
page
|
page
.
click_edit_ci_variable
page
.
click_ci_variable_delete_button
Page
::
Project
::
Settings
::
CiVariables
.
perform
do
|
ci_variable
|
ci_variable
.
click_edit_ci_variable
ci_variable
.
click_ci_variable_delete_button
expect
(
page
).
not_to
have_text
(
'VARIABLE_KEY'
)
end
expect
(
ci_variable
).
to
have_text
(
'There are no variables yet'
,
wait:
60
)
end
end
...
...
@@ -50,11 +46,6 @@ module QA
ci_variable
.
masked
=
false
end
end
def
open_ci_cd_settings
project
.
visit!
Page
::
Project
::
Menu
.
perform
(
&
:go_to_ci_cd_settings
)
end
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment