Merge branch 'remove-projects_ci_builds_metadata_project_id-fk' into 'master'

Swap FK ci_builds_metadata to projects for LFK

See merge request gitlab-org/gitlab!79039

db/post_migrate/20220124180704_remove_projects_ci_builds_metadata_project_id_fk.rb

+# frozen_string_literal: true
+
+class RemoveProjectsCiBuildsMetadataProjectIdFk < Gitlab::Database::Migration[1.0]
+  disable_ddl_transaction!
+
+  def up
+    return if Gitlab.com? # unsafe migration, skip on GitLab.com due to https://gitlab.com/groups/gitlab-org/-/epics/7249#note_819625526
+    return unless foreign_key_exists?(:ci_builds_metadata, :projects, name: "fk_rails_ffcf702a02")
+
+    with_lock_retries do
+      execute('LOCK projects, ci_builds_metadata IN ACCESS EXCLUSIVE MODE') if transaction_open?
+
+      remove_foreign_key_if_exists(:ci_builds_metadata, :projects, name: "fk_rails_ffcf702a02")
+    end
+  end
+
+  def down
+    add_concurrent_foreign_key(:ci_builds_metadata, :projects, name: "fk_rails_ffcf702a02", column: :project_id, target_column: :id, on_delete: :cascade)
+  end
+end

db/schema_migrations/20220124180704

+5b5f47f1d7038518fef71dd8c0758b234bb890be9aab57b78918f7b2dc39bdc4
\ No newline at end of file

db/structure.sql

@@ -31538,9 +31538,6 @@ ALTER TABLE ONLY resource_label_events
 ALTER TABLE ONLY pages_deployment_states
     ADD CONSTRAINT fk_rails_ff6ca551a4 FOREIGN KEY (pages_deployment_id) REFERENCES pages_deployments(id) ON DELETE CASCADE;
 
-ALTER TABLE ONLY ci_builds_metadata
-    ADD CONSTRAINT fk_rails_ffcf702a02 FOREIGN KEY (project_id) REFERENCES projects(id) ON DELETE CASCADE;
-
 ALTER TABLE ONLY security_orchestration_policy_configurations
     ADD CONSTRAINT fk_security_policy_configurations_management_project_id FOREIGN KEY (security_policy_management_project_id) REFERENCES projects(id) ON DELETE CASCADE;
 

lib/gitlab/database/gitlab_loose_foreign_keys.yml

@@ -132,6 +132,10 @@ pages_deployments:
   - table: ci_builds
     column: ci_build_id
     on_delete: async_nullify
+ci_builds_metadata:
+  - table: projects
+    column: project_id
+    on_delete: async_delete
 terraform_state_versions:
   - table: ci_builds
     column: ci_build_id

spec/factories/ci/build_metadata.rb

+# frozen_string_literal: true
+
+FactoryBot.define do
+  factory :ci_build_metadata, class: 'Ci::BuildMetadata' do
+    build { association(:ci_build, strategy: :build, metadata: instance) }
+  end
+end

spec/lib/gitlab/database/no_cross_db_foreign_keys_spec.rb

@@ -13,7 +13,6 @@ RSpec.describe 'cross-database foreign keys' do
     %w(
       ci_build_report_results.project_id
       ci_builds.project_id
-      ci_builds_metadata.project_id
       ci_daily_build_group_report_results.group_id
       ci_daily_build_group_report_results.project_id
       ci_freeze_periods.project_id

spec/models/ci/build_metadata_spec.rb

@@ -133,4 +133,11 @@ RSpec.describe Ci::BuildMetadata do
       expect(build.cancel_gracefully?).to be false
     end
   end
+
+  context 'loose foreign key on ci_builds_metadata.project_id' do
+    it_behaves_like 'cleanup by a loose foreign key' do
+      let!(:parent) { create(:project) }
+      let!(:model) { create(:ci_build_metadata, project: parent) }
+    end
+  end
 end