Commit 26946003 authored by Alper Akgun's avatar Alper Akgun

More spelling errors in docs

parent c9faf2ba
...@@ -368,7 +368,7 @@ then the query might perform worse than the non-optimized query. The `milestone_ ...@@ -368,7 +368,7 @@ then the query might perform worse than the non-optimized query. The `milestone_
"index_issues_on_milestone_id" btree (milestone_id) "index_issues_on_milestone_id" btree (milestone_id)
``` ```
Adding the `miletone_id = X` filter to the `scope` argument or to the optimized scope causes bad performance. Adding the `milestone_id = X` filter to the `scope` argument or to the optimized scope causes bad performance.
Example (bad): Example (bad):
...@@ -618,7 +618,7 @@ The following example shows the final `ORDER BY` clause: ...@@ -618,7 +618,7 @@ The following example shows the final `ORDER BY` clause:
ORDER BY extract('epoch' FROM epics.closed_at - epics.created_at) DESC, epics.id DESC ORDER BY extract('epoch' FROM epics.closed_at - epics.created_at) DESC, epics.id DESC
``` ```
Snippet for loading records ordered by the calcualted duration: Snippet for loading records ordered by the calculated duration:
```ruby ```ruby
arel_table = Epic.arel_table arel_table = Epic.arel_table
...@@ -641,7 +641,7 @@ records = Gitlab::Pagination::Keyset::InOperatorOptimization::QueryBuilder.new( ...@@ -641,7 +641,7 @@ records = Gitlab::Pagination::Keyset::InOperatorOptimization::QueryBuilder.new(
array_mapping_scope: -> (id_expression) { Epic.where(Epic.arel_table[:group_id].eq(id_expression)) } array_mapping_scope: -> (id_expression) { Epic.where(Epic.arel_table[:group_id].eq(id_expression)) }
).execute.limit(20) ).execute.limit(20)
puts records.pluck(:duration_in_seconds, :id) # other columnns are not available puts records.pluck(:duration_in_seconds, :id) # other columns are not available
``` ```
Building the query requires quite a bit of configuration. For the order configuration you Building the query requires quite a bit of configuration. For the order configuration you
......
...@@ -596,7 +596,7 @@ NOTE: ...@@ -596,7 +596,7 @@ NOTE:
This method of stubbing in Jest specs will not automatically un-stub itself at the end of the test. We merge our stubbed experiment in with all the other global data in `window.gl`. If you need to remove the stubbed experiment(s) after your test or ensure a clean global object before your test, you'll need to manage the global object directly yourself: This method of stubbing in Jest specs will not automatically un-stub itself at the end of the test. We merge our stubbed experiment in with all the other global data in `window.gl`. If you need to remove the stubbed experiment(s) after your test or ensure a clean global object before your test, you'll need to manage the global object directly yourself:
```javascript ```javascript
desribe('tests that care about global state', () => { describe('tests that care about global state', () => {
const originalObjects = []; const originalObjects = [];
beforeEach(() => { beforeEach(() => {
......
...@@ -268,7 +268,7 @@ On the EC2 dashboard, look for Load Balancer in the left navigation bar: ...@@ -268,7 +268,7 @@ On the EC2 dashboard, look for Load Balancer in the left navigation bar:
1. Click **Configure Health Check** and set up a health check for your EC2 instances. 1. Click **Configure Health Check** and set up a health check for your EC2 instances.
1. For **Ping Protocol**, select HTTP. 1. For **Ping Protocol**, select HTTP.
1. For **Ping Port**, enter 80. 1. For **Ping Port**, enter 80.
1. For **Ping Path** - we recommend that you [use the Readiness check endpoint](../../administration/load_balancer.md#readiness-check). You'll need to add [the VPC IP Adddress Range (CIDR)](https://docs.aws.amazon.com/elasticloadbalancing/latest/classic/elb-security-groups.html#elb-vpc-nacl) to the [IP Allowlist](../../administration/monitoring/ip_whitelist.md) for the [Health Check endpoints](../../user/admin_area/monitoring/health_check.md) 1. For **Ping Path** - we recommend that you [use the Readiness check endpoint](../../administration/load_balancer.md#readiness-check). You'll need to add [the VPC IP Address Range (CIDR)](https://docs.aws.amazon.com/elasticloadbalancing/latest/classic/elb-security-groups.html#elb-vpc-nacl) to the [IP Allowlist](../../administration/monitoring/ip_whitelist.md) for the [Health Check endpoints](../../user/admin_area/monitoring/health_check.md)
1. Keep the default **Advanced Details** or adjust them according to your needs. 1. Keep the default **Advanced Details** or adjust them according to your needs.
1. Click **Add EC2 Instances** - don't add anything as we will create an Auto Scaling Group later to manage instances for us. 1. Click **Add EC2 Instances** - don't add anything as we will create an Auto Scaling Group later to manage instances for us.
1. Click **Add Tags** and add any tags you need. 1. Click **Add Tags** and add any tags you need.
...@@ -588,8 +588,8 @@ Let's create an EC2 instance where we'll install Gitaly: ...@@ -588,8 +588,8 @@ Let's create an EC2 instance where we'll install Gitaly:
1. In the **Subnet** dropdown, select `gitlab-private-10.0.1.0` from the list of subnets we created earlier. 1. In the **Subnet** dropdown, select `gitlab-private-10.0.1.0` from the list of subnets we created earlier.
1. Double check that **Auto-assign Public IP** is set to `Use subnet setting (Disable)`. 1. Double check that **Auto-assign Public IP** is set to `Use subnet setting (Disable)`.
1. Click **Add Storage**. 1. Click **Add Storage**.
1. Increase the Root volume size to `20 GiB` and change the **Volume Type** to `Provisoned IOPS SSD (io1)`. (This is an arbitrary size. Create a volume big enough for your repository storage requirements.) 1. Increase the Root volume size to `20 GiB` and change the **Volume Type** to `Provisioned IOPS SSD (io1)`. (This is an arbitrary size. Create a volume big enough for your repository storage requirements.)
1. For **IOPS** set `1000` (20 GiB x 50 IOPS). You can provision up to 50 IOPS per GiB. If you select a larger volume, increase the IOPS accordingly. Workloads where many small files are written in a serialized manner, like `git`, requires performant storage, hence the choice of `Provisoned IOPS SSD (io1)`. 1. For **IOPS** set `1000` (20 GiB x 50 IOPS). You can provision up to 50 IOPS per GiB. If you select a larger volume, increase the IOPS accordingly. Workloads where many small files are written in a serialized manner, like `git`, requires performant storage, hence the choice of `Provisioned IOPS SSD (io1)`.
1. Click on **Add Tags** and add your tags. In our case, we'll only set `Key: Name` and `Value: Gitaly`. 1. Click on **Add Tags** and add your tags. In our case, we'll only set `Key: Name` and `Value: Gitaly`.
1. Click on **Configure Security Group** and let's **Create a new security group**. 1. Click on **Configure Security Group** and let's **Create a new security group**.
1. Give your security group a name and description. We'll use `gitlab-gitaly-sec-group` for both. 1. Give your security group a name and description. We'll use `gitlab-gitaly-sec-group` for both.
......
...@@ -146,7 +146,7 @@ RSpec.describe Releases::CreateService do ...@@ -146,7 +146,7 @@ RSpec.describe Releases::CreateService do
end end
end end
context 'when multiple miletone titles are passed in but one of them does not exist' do context 'when multiple milestone titles are passed in but one of them does not exist' do
let(:title) { 'v1.0' } let(:title) { 'v1.0' }
let(:inexistent_title) { 'v111.0' } let(:inexistent_title) { 'v111.0' }
let!(:milestone) { create(:milestone, :active, project: project, title: title) } let!(:milestone) { create(:milestone, :active, project: project, title: title) }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment