Merge branch 'dg-unused-variables' into 'master'

Eliminate warnings about unused variables

See merge request gitlab-org/gitlab!23080

db/fixtures/development/07_milestones.rb

@@ -9,8 +9,7 @@ Gitlab::Seeder.quiet do
         state: [:active, :closed].sample,
       }
 
-      milestone = Milestones::CreateService.new(
-        project, project.team.users.sample, milestone_params).execute
+      Milestones::CreateService.new(project, project.team.users.sample, milestone_params).execute
 
       print '.'
     end

ee/lib/gitlab/contribution_analytics/data_collector.rb

@@ -45,7 +45,7 @@ module Gitlab
       end
 
       def total_events_by_author_count
-        all_counts.each_with_object({}) do |((author_id, target_type, action), count), hash|
+        all_counts.each_with_object({}) do |((author_id, _target_type, _action), count), hash|
           hash[author_id] ||= 0
           hash[author_id] += count
         end

lib/gitlab/git/gitmodules_parser.rb

@@ -71,7 +71,7 @@ module Gitlab
         # Convert from an indexed by name to an array indexed by path
         # If a submodule doesn't have a path, it is considered bogus
         # and is ignored
-        submodules_by_name.each_with_object({}) do |(name, data), results|
+        submodules_by_name.each_with_object({}) do |(_name, data), results|
           path = data.delete 'path'
           next unless path
 

spec/support/cycle_analytics_helpers/test_generation.rb

@@ -117,7 +117,7 @@ module CycleAnalyticsHelpers
               data = data_fn[self]
               end_time = rand(1..10).days.from_now
 
-              end_time_conditions.each_with_index do |(condition_name, condition_fn), index|
+              end_time_conditions.each_with_index do |(_condition_name, condition_fn), index|
                 Timecop.freeze(end_time + index.days) { condition_fn[self, data] }
               end