Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
27a5e100
Commit
27a5e100
authored
Oct 13, 2020
by
Kamil Trzciński
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove `ci_bridge_pipeline_details` feature flag
The feature is stable, we no longer need this feature flag.
parent
6c786146
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
0 additions
and
17 deletions
+0
-17
config/feature_flags/development/ci_bridge_pipeline_details.yml
.../feature_flags/development/ci_bridge_pipeline_details.yml
+0
-7
lib/gitlab/ci/status/bridge/common.rb
lib/gitlab/ci/status/bridge/common.rb
+0
-1
spec/lib/gitlab/ci/status/bridge/common_spec.rb
spec/lib/gitlab/ci/status/bridge/common_spec.rb
+0
-9
No files found.
config/feature_flags/development/ci_bridge_pipeline_details.yml
deleted
100644 → 0
View file @
6c786146
---
name
:
ci_bridge_pipeline_details
introduced_by_url
:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/41263
rollout_issue_url
:
https://gitlab.com/gitlab-org/gitlab/-/issues/250683
group
:
group::memory
type
:
development
default_enabled
:
true
lib/gitlab/ci/status/bridge/common.rb
View file @
27a5e100
...
...
@@ -14,7 +14,6 @@ module Gitlab
end
def
details_path
return
unless
Feature
.
enabled?
(
:ci_bridge_pipeline_details
,
subject
.
project
,
default_enabled:
true
)
return
unless
can?
(
user
,
:read_pipeline
,
downstream_pipeline
)
project_pipeline_path
(
downstream_project
,
downstream_pipeline
)
...
...
spec/lib/gitlab/ci/status/bridge/common_spec.rb
View file @
27a5e100
...
...
@@ -30,15 +30,6 @@ RSpec.describe Gitlab::Ci::Status::Bridge::Common do
it
{
expect
(
subject
).
to
have_details
}
it
{
expect
(
subject
.
details_path
).
to
include
"pipelines/
#{
downstream_pipeline
.
id
}
"
}
context
'when ci_bridge_pipeline_details is disabled'
do
before
do
stub_feature_flags
(
ci_bridge_pipeline_details:
false
)
end
it
{
expect
(
subject
).
not_to
have_details
}
it
{
expect
(
subject
.
details_path
).
to
be_nil
}
end
end
context
'when user does not have access to read downstream pipeline'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment