Commit 28d3068f authored by David O'Regan's avatar David O'Regan

Merge branch 'issue#325836-fix-empty-line-after-let-it-be-gitlab-jira-import' into 'master'

Fix EmptyLineAfterFinalLetItBe offenses in spec/lib/gitlab/jira_import

See merge request gitlab-org/gitlab!58266
parents 3c2c533b 9b2eecb5
...@@ -802,9 +802,6 @@ RSpec/EmptyLineAfterFinalLetItBe: ...@@ -802,9 +802,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
- spec/lib/gitlab/hook_data/issue_builder_spec.rb - spec/lib/gitlab/hook_data/issue_builder_spec.rb
- spec/lib/gitlab/hook_data/merge_request_builder_spec.rb - spec/lib/gitlab/hook_data/merge_request_builder_spec.rb
- spec/lib/gitlab/hook_data/release_builder_spec.rb - spec/lib/gitlab/hook_data/release_builder_spec.rb
- spec/lib/gitlab/jira_import/base_importer_spec.rb
- spec/lib/gitlab/jira_import/handle_labels_service_spec.rb
- spec/lib/gitlab/jira_import_spec.rb
- spec/lib/gitlab/json_cache_spec.rb - spec/lib/gitlab/json_cache_spec.rb
- spec/lib/gitlab/language_detection_spec.rb - spec/lib/gitlab/language_detection_spec.rb
- spec/lib/gitlab/project_search_results_spec.rb - spec/lib/gitlab/project_search_results_spec.rb
......
---
title: Fix EmptyLineAfterFinalLetItBe offenses in spec/lib/gitlab/jira_import
merge_request: 58266
author: Huzaifa Iftikhar @huzaifaiftikhar
type: fixed
...@@ -27,6 +27,7 @@ RSpec.describe Gitlab::JiraImport::BaseImporter do ...@@ -27,6 +27,7 @@ RSpec.describe Gitlab::JiraImport::BaseImporter do
context 'when import data exists' do context 'when import data exists' do
let_it_be(:project) { create(:project) } let_it_be(:project) { create(:project) }
let_it_be(:jira_import) { create(:jira_import_state, project: project) } let_it_be(:jira_import) { create(:jira_import_state, project: project) }
let(:subject) { described_class.new(project) } let(:subject) { described_class.new(project) }
context 'when #imported_items_cache_key is not implemented' do context 'when #imported_items_cache_key is not implemented' do
......
...@@ -10,6 +10,7 @@ RSpec.describe Gitlab::JiraImport::HandleLabelsService do ...@@ -10,6 +10,7 @@ RSpec.describe Gitlab::JiraImport::HandleLabelsService do
let_it_be(:project_label) { create(:label, project: project, title: 'bug') } let_it_be(:project_label) { create(:label, project: project, title: 'bug') }
let_it_be(:other_project_label) { create(:label, title: 'feature') } let_it_be(:other_project_label) { create(:label, title: 'feature') }
let_it_be(:group_label) { create(:group_label, group: group, title: 'dev') } let_it_be(:group_label) { create(:group_label, group: group, title: 'dev') }
let(:jira_labels) { %w(bug feature dev group::new) } let(:jira_labels) { %w(bug feature dev group::new) }
subject { described_class.new(project, jira_labels).execute } subject { described_class.new(project, jira_labels).execute }
......
...@@ -9,6 +9,7 @@ RSpec.describe Gitlab::JiraImport do ...@@ -9,6 +9,7 @@ RSpec.describe Gitlab::JiraImport do
include JiraServiceHelper include JiraServiceHelper
let_it_be(:project, reload: true) { create(:project) } let_it_be(:project, reload: true) { create(:project) }
let(:additional_params) { {} } let(:additional_params) { {} }
subject { described_class.validate_project_settings!(project, **additional_params) } subject { described_class.validate_project_settings!(project, **additional_params) }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment