Revert priority ordering

app/helpers/analytics_navbar_helper.rb

@@ -14,7 +14,7 @@ module AnalyticsNavbarHelper
 
   def project_analytics_navbar_links(project, current_user)
     [
-      cycle_analytics_navbar_link(project, current_user, -1),
+      cycle_analytics_navbar_link(project, current_user),
       repository_analytics_navbar_link(project, current_user),
       ci_cd_analytics_navbar_link(project, current_user)
     ].compact
@@ -30,37 +30,36 @@ module AnalyticsNavbarHelper
     NavbarSubItem.new(args)
   end
 
-  def cycle_analytics_navbar_link(project, current_user, priority = 0)
+  def cycle_analytics_navbar_link(project, current_user)
     return unless project_nav_tab?(:cycle_analytics)
 
     navbar_sub_item(
       title: _('Value Stream'),
       path: 'cycle_analytics#show',
       link: project_cycle_analytics_path(project),
-      link_to_options: { class: 'shortcuts-project-cycle-analytics', data: { priority: priority } }
+      link_to_options: { class: 'shortcuts-project-cycle-analytics' }
     )
   end
 
-  def repository_analytics_navbar_link(project, current_user, priority = 0)
+  def repository_analytics_navbar_link(project, current_user)
     return if project.empty_repo?
 
     navbar_sub_item(
       title: _('Repository'),
       path: 'graphs#charts',
       link: charts_project_graph_path(project, current_ref),
-      link_to_options: { class: 'shortcuts-repository-charts', data: { priority: priority } }
+      link_to_options: { class: 'shortcuts-repository-charts' }
     )
   end
 
-  def ci_cd_analytics_navbar_link(project, current_user, priority = 0)
+  def ci_cd_analytics_navbar_link(project, current_user)
     return unless project_nav_tab?(:pipelines)
     return unless project.feature_available?(:builds, current_user) || !project.empty_repo?
 
     navbar_sub_item(
       title: _('CI / CD'),
       path: 'pipelines#charts',
-      link: charts_project_pipelines_path(project),
-      link_to_options: { data: { priority: priority } }
+      link: charts_project_pipelines_path(project)
     )
   end
 end

ee/app/helpers/ee/analytics_navbar_helper.rb

@@ -26,15 +26,14 @@ module EE
 
     private
 
-    def project_issues_analytics_navbar_link(project, current_user, priority = 0)
+    def project_issues_analytics_navbar_link(project, current_user)
       return unless ::Feature.enabled?(:project_level_issues_analytics, project, default_enabled: true)
       return unless project_nav_tab?(:issues_analytics)
 
       navbar_sub_item(
         title: _('Issues'),
         path: 'issues_analytics#show',
-        link: project_analytics_issues_analytics_path(project),
-        link_to_options: { data: { priority: priority } }
+        link: project_analytics_issues_analytics_path(project)
       )
     end
 
@@ -90,25 +89,24 @@ module EE
       )
     end
 
-    def insights_navbar_link(project, current_user, priority = 0)
+    def insights_navbar_link(project, current_user)
       return unless project_nav_tab?(:project_insights)
 
       navbar_sub_item(
         title: _('Insights'),
         path: 'insights#show',
         link: project_insights_path(project),
-        link_to_options: { class: 'shortcuts-project-insights', data: { qa_selector: 'project_insights_link', priority: priority } }
+        link_to_options: { class: 'shortcuts-project-insights', data: { qa_selector: 'project_insights_link' } }
       )
     end
 
-    def code_review_analytics_navbar_link(project, current_user, priority = 0)
+    def code_review_analytics_navbar_link(project, current_user)
       return unless project_nav_tab?(:code_review)
 
       navbar_sub_item(
         title: _('Code Review'),
         path: 'projects/analytics/code_reviews#index',
-        link: project_analytics_code_reviews_path(project),
-        link_to_options: { data: { priority: priority } }
+        link: project_analytics_code_reviews_path(project)
       )
     end
   end