Merge branch 'sy-rename-project-metrics' into 'master'

Renames the ProjectMetrics to name the team uses CustomMetrics

See merge request gitlab-org/gitlab!27433

app/services/metrics/dashboard/clone_dashboard_service.rb

@@ -16,7 +16,7 @@ module Metrics
         def sequences
           @sequences ||= {
             ::Metrics::Dashboard::SystemDashboardService::DASHBOARD_PATH => [::Gitlab::Metrics::Dashboard::Stages::CommonMetricsInserter,
-                                                                             ::Gitlab::Metrics::Dashboard::Stages::ProjectMetricsInserter,
+                                                                             ::Gitlab::Metrics::Dashboard::Stages::CustomMetricsInserter,
                                                                              ::Gitlab::Metrics::Dashboard::Stages::Sorter].freeze
           }.freeze
         end

app/services/metrics/dashboard/self_monitoring_dashboard_service.rb

@@ -9,7 +9,7 @@ module Metrics
       DASHBOARD_NAME = 'Default'
 
       SEQUENCE = [
-        STAGES::ProjectMetricsInserter,
+        STAGES::CustomMetricsInserter,
         STAGES::EndpointInserter,
         STAGES::Sorter
       ].freeze

app/services/metrics/dashboard/system_dashboard_service.rb

@@ -10,8 +10,8 @@ module Metrics
 
       SEQUENCE = [
         STAGES::CommonMetricsInserter,
-        STAGES::ProjectMetricsInserter,
-        STAGES::ProjectMetricsDetailsInserter,
+        STAGES::CustomMetricsInserter,
+        STAGES::CustomMetricsDetailsInserter,
         STAGES::EndpointInserter,
         STAGES::Sorter
       ].freeze

ee/spec/lib/ee/gitlab/metrics/dashboard/processor_spec.rb

@@ -13,7 +13,7 @@ describe Gitlab::Metrics::Dashboard::Processor do
     let(:sequence) do
       [
         Gitlab::Metrics::Dashboard::Stages::CommonMetricsInserter,
-        Gitlab::Metrics::Dashboard::Stages::ProjectMetricsInserter,
+        Gitlab::Metrics::Dashboard::Stages::CustomMetricsInserter,
         Gitlab::Metrics::Dashboard::Stages::EndpointInserter,
         Gitlab::Metrics::Dashboard::Stages::Sorter,
         ::EE::Gitlab::Metrics::Dashboard::Stages::AlertsInserter

ee/spec/services/metrics/dashboard/clone_dashboard_service_spec.rb

@@ -31,7 +31,7 @@ describe Metrics::Dashboard::CloneDashboardService, :use_clean_rails_memory_stor
           }
         end
 
-        it_behaves_like 'valid dashboard cloning process', ::Metrics::Dashboard::SystemDashboardService::DASHBOARD_PATH, [STAGES::CommonMetricsInserter, STAGES::ProjectMetricsInserter, STAGES::Sorter]
+        it_behaves_like 'valid dashboard cloning process', ::Metrics::Dashboard::SystemDashboardService::DASHBOARD_PATH, [STAGES::CommonMetricsInserter, STAGES::CustomMetricsInserter, STAGES::Sorter]
         it_behaves_like 'valid dashboard cloning process', ::Metrics::Dashboard::ClusterDashboardService::DASHBOARD_PATH, [STAGES::CommonMetricsInserter, STAGES::Sorter]
       end
     end

lib/gitlab/metrics/dashboard/stages/project_metrics_details_inserter.rb → lib/gitlab/metrics/dashboard/stages/custom_metrics_details_inserter.rb

@@ -4,7 +4,7 @@ module Gitlab
   module Metrics
     module Dashboard
       module Stages
-        class ProjectMetricsDetailsInserter < BaseStage
+        class CustomMetricsDetailsInserter < BaseStage
           def transform!
             dashboard[:panel_groups].each do |panel_group|
               next unless panel_group

lib/gitlab/metrics/dashboard/stages/project_metrics_inserter.rb → lib/gitlab/metrics/dashboard/stages/custom_metrics_inserter.rb

@@ -4,7 +4,7 @@ module Gitlab
   module Metrics
     module Dashboard
       module Stages
-        class ProjectMetricsInserter < BaseStage
+        class CustomMetricsInserter < BaseStage
           # Inserts project-specific metrics into the dashboard
           # config. If there are no project-specific metrics,
           # this will have no effect.

spec/lib/gitlab/metrics/dashboard/processor_spec.rb

@@ -11,8 +11,8 @@ describe Gitlab::Metrics::Dashboard::Processor do
     let(:sequence) do
       [
         Gitlab::Metrics::Dashboard::Stages::CommonMetricsInserter,
-        Gitlab::Metrics::Dashboard::Stages::ProjectMetricsInserter,
-        Gitlab::Metrics::Dashboard::Stages::ProjectMetricsDetailsInserter,
+        Gitlab::Metrics::Dashboard::Stages::CustomMetricsInserter,
+        Gitlab::Metrics::Dashboard::Stages::CustomMetricsDetailsInserter,
         Gitlab::Metrics::Dashboard::Stages::EndpointInserter,
         Gitlab::Metrics::Dashboard::Stages::Sorter
       ]

spec/services/metrics/dashboard/clone_dashboard_service_spec.rb

@@ -83,7 +83,7 @@ describe Metrics::Dashboard::CloneDashboardService, :use_clean_rails_memory_stor
           allow(::Gitlab::Metrics::Dashboard::Processor).to receive(:new).and_return(double(process: file_content_hash))
         end
 
-        it_behaves_like 'valid dashboard cloning process', ::Metrics::Dashboard::SystemDashboardService::DASHBOARD_PATH, [STAGES::CommonMetricsInserter, STAGES::ProjectMetricsInserter, STAGES::Sorter]
+        it_behaves_like 'valid dashboard cloning process', ::Metrics::Dashboard::SystemDashboardService::DASHBOARD_PATH, [STAGES::CommonMetricsInserter, STAGES::CustomMetricsInserter, STAGES::Sorter]
 
         context 'selected branch already exists' do
           let(:branch) { 'existing_branch' }