Merge branch 'if-share_groups_with_groups-fix_set' into 'master'

Replace set with let_it_be in share groups with groups changes

See merge request gitlab-org/gitlab!19553

spec/lib/gitlab/project_authorizations_spec.rb

@@ -77,17 +77,17 @@ describe Gitlab::ProjectAuthorizations do
     let(:group_user) { create(:user) }
     let(:child_group_user) { create(:user) }
 
-    set(:group_parent) { create(:group, :private) }
-    set(:group) { create(:group, :private, parent: group_parent) }
-    set(:group_child) { create(:group, :private, parent: group) }
+    let_it_be(:group_parent) { create(:group, :private) }
+    let_it_be(:group) { create(:group, :private, parent: group_parent) }
+    let_it_be(:group_child) { create(:group, :private, parent: group) }
 
-    set(:shared_group_parent) { create(:group, :private) }
-    set(:shared_group) { create(:group, :private, parent: shared_group_parent) }
-    set(:shared_group_child) { create(:group, :private, parent: shared_group) }
+    let_it_be(:shared_group_parent) { create(:group, :private) }
+    let_it_be(:shared_group) { create(:group, :private, parent: shared_group_parent) }
+    let_it_be(:shared_group_child) { create(:group, :private, parent: shared_group) }
 
-    set(:project_parent) { create(:project, group: shared_group_parent) }
-    set(:project) { create(:project, group: shared_group) }
-    set(:project_child) { create(:project, group: shared_group_child) }
+    let_it_be(:project_parent) { create(:project, group: shared_group_parent) }
+    let_it_be(:project) { create(:project, group: shared_group) }
+    let_it_be(:project_child) { create(:project, group: shared_group_child) }
 
     before do
       group_parent.add_owner(parent_group_user)

spec/models/group_spec.rb

@@ -531,13 +531,13 @@ describe Group do
       let(:group_user) { create(:user) }
       let(:child_group_user) { create(:user) }
 
-      set(:group_parent) { create(:group, :private) }
-      set(:group) { create(:group, :private, parent: group_parent) }
-      set(:group_child) { create(:group, :private, parent: group) }
+      let_it_be(:group_parent) { create(:group, :private) }
+      let_it_be(:group) { create(:group, :private, parent: group_parent) }
+      let_it_be(:group_child) { create(:group, :private, parent: group) }
 
-      set(:shared_group_parent) { create(:group, :private) }
-      set(:shared_group) { create(:group, :private, parent: shared_group_parent) }
-      set(:shared_group_child) { create(:group, :private, parent: shared_group) }
+      let_it_be(:shared_group_parent) { create(:group, :private) }
+      let_it_be(:shared_group) { create(:group, :private, parent: shared_group_parent) }
+      let_it_be(:shared_group_child) { create(:group, :private, parent: shared_group) }
 
       before do
         group_parent.add_owner(parent_group_user)

spec/services/groups/group_links/create_service_spec.rb

@@ -7,17 +7,17 @@ describe Groups::GroupLinks::CreateService, '#execute' do
   let(:group_user) { create(:user) }
   let(:child_group_user) { create(:user) }
 
-  set(:group_parent) { create(:group, :private) }
-  set(:group) { create(:group, :private, parent: group_parent) }
-  set(:group_child) { create(:group, :private, parent: group) }
+  let_it_be(:group_parent) { create(:group, :private) }
+  let_it_be(:group) { create(:group, :private, parent: group_parent) }
+  let_it_be(:group_child) { create(:group, :private, parent: group) }
 
-  set(:shared_group_parent) { create(:group, :private) }
-  set(:shared_group) { create(:group, :private, parent: shared_group_parent) }
-  set(:shared_group_child) { create(:group, :private, parent: shared_group) }
+  let_it_be(:shared_group_parent) { create(:group, :private) }
+  let_it_be(:shared_group) { create(:group, :private, parent: shared_group_parent) }
+  let_it_be(:shared_group_child) { create(:group, :private, parent: shared_group) }
 
-  set(:project_parent) { create(:project, group: shared_group_parent) }
-  set(:project) { create(:project, group: shared_group) }
-  set(:project_child) { create(:project, group: shared_group_child) }
+  let_it_be(:project_parent) { create(:project, group: shared_group_parent) }
+  let_it_be(:project) { create(:project, group: shared_group) }
+  let_it_be(:project_child) { create(:project, group: shared_group_child) }
 
   let(:opts) do
     {