Commit 2b42ff9d authored by Kassio Borges's avatar Kassio Borges

Remove github_import_pull_request_reviews feature flag

Remove Feature flag introduced in
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/48632. This
feature is being used since then without any known bugs.

Related to:
- https://gitlab.com/gitlab-org/gitlab/-/issues/289153
- https://gitlab.com/gitlab-org/gitlab/-/merge_requests/48632
parent 4709d3c9
...@@ -11,18 +11,11 @@ module Gitlab ...@@ -11,18 +11,11 @@ module Gitlab
# client - An instance of Gitlab::GithubImport::Client. # client - An instance of Gitlab::GithubImport::Client.
# project - An instance of Project. # project - An instance of Project.
def import(client, project) def import(client, project)
waiter = waiter = Importer::PullRequestsReviewsImporter
if Feature.enabled?(:github_import_pull_request_reviews, project, default_enabled: true) .new(project, client)
waiter = Importer::PullRequestsReviewsImporter .execute
.new(project, client)
.execute
project.import_state.refresh_jid_expiration project.import_state.refresh_jid_expiration
waiter
else
JobWaiter.new
end
AdvanceStageWorker.perform_async( AdvanceStageWorker.perform_async(
project.id, project.id,
......
---
name: github_import_pull_request_reviews
introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/48632
rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/289153
milestone: '13.7'
type: development
group: group::import
default_enabled: true
...@@ -9,23 +9,7 @@ RSpec.describe Gitlab::GithubImport::Stage::ImportPullRequestsReviewsWorker do ...@@ -9,23 +9,7 @@ RSpec.describe Gitlab::GithubImport::Stage::ImportPullRequestsReviewsWorker do
let(:client) { double(:client) } let(:client) { double(:client) }
describe '#import' do describe '#import' do
it 'does not import with the feature disabled' do
stub_feature_flags(github_import_pull_request_reviews: false)
expect(Gitlab::JobWaiter)
.to receive(:new)
.and_return(double(key: '123', jobs_remaining: 0))
expect(Gitlab::GithubImport::AdvanceStageWorker)
.to receive(:perform_async)
.with(project.id, { '123' => 0 }, :issues_and_diff_notes)
worker.import(client, project)
end
it 'imports all the pull request reviews' do it 'imports all the pull request reviews' do
stub_feature_flags(github_import_pull_request_reviews: true)
importer = double(:importer) importer = double(:importer)
waiter = Gitlab::JobWaiter.new(2, '123') waiter = Gitlab::JobWaiter.new(2, '123')
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment