Commit 2b82ab1c authored by João Cunha's avatar João Cunha

Remove string concat duplicated logic from services

parent f2f98d7f
......@@ -37,7 +37,7 @@ module Clusters
has_one :platform_kubernetes, class_name: 'Clusters::Platforms::Kubernetes', inverse_of: :cluster, autosave: true
def self.has_one_cluster_application(name)
def self.has_one_cluster_application(name) # rubocop:disable Naming/PredicateName
application = APPLICATIONS[name.to_s]
has_one application.association_name, class_name: application.to_s # rubocop:disable Rails/ReflectionClassName
end
......
......@@ -77,6 +77,10 @@ module Clusters
params[:application]
end
def application_class
Clusters::Cluster::APPLICATIONS[application_name]
end
def create_oauth_application(application, request)
oauth_application_params = {
name: params[:application],
......
......@@ -10,7 +10,7 @@ module Clusters
end
def builder
cluster.public_send(:"application_#{application_name}") || # rubocop:disable GitlabSecurity/PublicSend
cluster.public_send(application_class.association_name) || # rubocop:disable GitlabSecurity/PublicSend
cluster.public_send(:"build_application_#{application_name}") # rubocop:disable GitlabSecurity/PublicSend
end
end
......
......@@ -16,7 +16,7 @@ module Clusters
private
def builder
cluster.public_send(:"application_#{application_name}") # rubocop:disable GitlabSecurity/PublicSend
cluster.public_send(application_class.association_name) # rubocop:disable GitlabSecurity/PublicSend
end
end
end
......
......@@ -10,7 +10,7 @@ module Clusters
end
def builder
cluster.public_send(:"application_#{application_name}") # rubocop:disable GitlabSecurity/PublicSend
cluster.public_send(application_class.association_name) # rubocop:disable GitlabSecurity/PublicSend
end
end
end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment