Commit 2b9355e6 authored by Nicolò Maria Mezzopera's avatar Nicolò Maria Mezzopera

Merge branch 'cngo-update-settings_dropdown' into 'master'

Update settings_dropdown.vue to use text-sr-only attribute

See merge request gitlab-org/gitlab!48681
parents 8de753e5 86227e4c
<script> <script>
import { mapActions, mapGetters, mapState } from 'vuex'; import { mapActions, mapGetters, mapState } from 'vuex';
import { GlButtonGroup, GlButton, GlDropdown } from '@gitlab/ui'; import { GlButtonGroup, GlButton, GlDropdown } from '@gitlab/ui';
import { __ } from '~/locale';
export default { export default {
components: { components: {
...@@ -13,12 +12,6 @@ export default { ...@@ -13,12 +12,6 @@ export default {
...mapGetters('diffs', ['isInlineView', 'isParallelView']), ...mapGetters('diffs', ['isInlineView', 'isParallelView']),
...mapState('diffs', ['renderTreeList', 'showWhitespace']), ...mapState('diffs', ['renderTreeList', 'showWhitespace']),
}, },
mounted() {
this.patchAriaLabel();
},
updated() {
this.patchAriaLabel();
},
methods: { methods: {
...mapActions('diffs', [ ...mapActions('diffs', [
'setInlineDiffViewType', 'setInlineDiffViewType',
...@@ -26,17 +19,18 @@ export default { ...@@ -26,17 +19,18 @@ export default {
'setRenderTreeList', 'setRenderTreeList',
'setShowWhitespace', 'setShowWhitespace',
]), ]),
patchAriaLabel() {
this.$el
.querySelector('.js-show-diff-settings')
.setAttribute('aria-label', __('Diff view settings'));
},
}, },
}; };
</script> </script>
<template> <template>
<gl-dropdown icon="settings" toggle-class="js-show-diff-settings" right> <gl-dropdown
icon="settings"
:text="__('Diff view settings')"
:text-sr-only="true"
toggle-class="js-show-diff-settings"
right
>
<div class="gl-px-3"> <div class="gl-px-3">
<span class="gl-font-weight-bold gl-display-block gl-mb-2">{{ __('File browser') }}</span> <span class="gl-font-weight-bold gl-display-block gl-mb-2">{{ __('File browser') }}</span>
<gl-button-group class="gl-display-flex"> <gl-button-group class="gl-display-flex">
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment