Merge branch 'sh-fix-gocloud-race' into 'master'

Eliminate unnecessary code in GoCloud test stubs

See merge request gitlab-org/gitlab-workhorse!590

changelogs/unreleased/sh-fix-gocloud-race.yml

+---
+title: Eliminate unnecessary code in GoCloud test stubs
+merge_request: 590
+author:
+type: other

internal/objectstore/test/gocloud_stub.go

@@ -13,12 +13,10 @@ import (
 )
 
 type dirOpener struct {
-	u      *url.URL // last url passed to OpenBucketURL
 	tmpDir string
 }
 
 func (o *dirOpener) OpenBucketURL(ctx context.Context, u *url.URL) (*blob.Bucket, error) {
-	o.u = u
 	return fileblob.OpenBucket(o.tmpDir, nil)
 }