Merge branch '220494-setup-controller-and-routing-for-group-mr-activity-report-page' into 'master'

Add route, controller and view for generic reports page

See merge request gitlab-org/gitlab!35011

ee/app/controllers/analytics/reports/pages_controller.rb

+# frozen_string_literal: true
+
+module Analytics
+  module Reports
+    class PagesController < ::ApplicationController
+      layout 'report_pages'
+
+      before_action do
+        render_404 unless feature_enabled? && feature_available?
+      end
+
+      def feature_enabled?
+        Feature.enabled?(Gitlab::Analytics::REPORT_PAGES_FEATURE_FLAG)
+      end
+
+      def feature_available?
+        ::License.feature_available?(:group_activity_analytics)
+      end
+    end
+  end
+end

ee/app/views/analytics/reports/pages/show.html.haml

+- page_title _("Reports")
+

ee/app/views/layouts/report_pages.html.haml

+- page_title _('Reports')
+
+= render template: 'layouts/application'

ee/config/routes/analytics.rb

@@ -3,6 +3,10 @@
 namespace :analytics do
   root to: 'analytics#index'
 
+  constraints(::Constraints::FeatureConstrainer.new(Gitlab::Analytics::REPORT_PAGES_FEATURE_FLAG)) do
+    get :report_pages, to: 'reports/pages#show'
+  end
+
   constraints(-> (req) { Gitlab::Analytics.cycle_analytics_enabled? }) do
     resource :cycle_analytics, only: :show, path: 'value_stream_analytics'
     scope module: :cycle_analytics, as: 'cycle_analytics', path: 'value_stream_analytics' do

ee/lib/gitlab/analytics.rb

@@ -5,15 +5,18 @@ module Gitlab
     # Normally each analytics feature should be guarded with a feature flag.
     CYCLE_ANALYTICS_FEATURE_FLAG = :cycle_analytics
     PRODUCTIVITY_ANALYTICS_FEATURE_FLAG = :productivity_analytics
+    REPORT_PAGES_FEATURE_FLAG = :report_pages
 
     FEATURE_FLAGS = [
       CYCLE_ANALYTICS_FEATURE_FLAG,
-      PRODUCTIVITY_ANALYTICS_FEATURE_FLAG
+      PRODUCTIVITY_ANALYTICS_FEATURE_FLAG,
+      REPORT_PAGES_FEATURE_FLAG
     ].freeze
 
     FEATURE_FLAG_DEFAULTS = {
       PRODUCTIVITY_ANALYTICS_FEATURE_FLAG => true,
-      CYCLE_ANALYTICS_FEATURE_FLAG => true
+      CYCLE_ANALYTICS_FEATURE_FLAG => true,
+      REPORT_PAGES_FEATURE_FLAG => false
     }.freeze
 
     def self.any_features_enabled?
@@ -28,6 +31,10 @@ module Gitlab
       feature_enabled?(PRODUCTIVITY_ANALYTICS_FEATURE_FLAG)
     end
 
+    def self.report_pages_enabled?
+      feature_enabled?(REPORT_PAGES_FEATURE_FLAG)
+    end
+
     def self.feature_enabled_by_default?(flag)
       !!FEATURE_FLAG_DEFAULTS[flag]
     end

ee/spec/controllers/analytics/reports/pages_controller_spec.rb

+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe Analytics::Reports::PagesController do
+  let(:user) { create(:user) }
+
+  before do
+    sign_in(user)
+
+    stub_licensed_features(group_activity_analytics: true)
+    stub_feature_flags(Gitlab::Analytics::REPORT_PAGES_FEATURE_FLAG => true)
+  end
+
+  describe 'GET show' do
+    it 'renders the report page' do
+      get :show
+
+      expect(response).to render_template :show
+    end
+
+    context 'when the feature flag is false' do
+      before do
+        stub_feature_flags(Gitlab::Analytics::REPORT_PAGES_FEATURE_FLAG => false)
+      end
+
+      it 'renders 404, not found' do
+        get :show
+
+        expect(response).to have_gitlab_http_status(:not_found)
+      end
+    end
+
+    context 'when the feature is not available' do
+      before do
+        stub_licensed_features(group_activity_analytics: false)
+      end
+
+      it 'renders 404, not found' do
+        get :show
+
+        expect(response).to have_gitlab_http_status(:not_found)
+      end
+    end
+  end
+end

locale/gitlab.pot

@@ -19057,6 +19057,9 @@ msgstr ""
 msgid "Reporting"
 msgstr ""
 
+msgid "Reports"
+msgstr ""
+
 msgid "Reports|%{combinedString} and %{resolvedString}"
 msgstr ""