Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
2db2a8a1
Commit
2db2a8a1
authored
Jun 15, 2021
by
Alexander Turinske
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Update sidebar edit tests to be more readable
parent
5cbea3ae
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
4 additions
and
4 deletions
+4
-4
app/assets/javascripts/vue_shared/alert_details/components/sidebar/sidebar_status.vue
...hared/alert_details/components/sidebar/sidebar_status.vue
+0
-1
spec/frontend/vue_shared/alert_details/sidebar/alert_sidebar_status_spec.js
...shared/alert_details/sidebar/alert_sidebar_status_spec.js
+4
-3
No files found.
app/assets/javascripts/vue_shared/alert_details/components/sidebar/sidebar_status.vue
View file @
2db2a8a1
...
...
@@ -100,7 +100,6 @@ export default {
<gl-button
v-if=
"isEditable"
class=
"gl-text-black-normal!"
data-testid=
"edit-status"
variant=
"link"
@
click=
"toggleFormDropdown"
@
keydown.esc=
"hideDropdown"
...
...
spec/frontend/vue_shared/alert_details/sidebar/alert_sidebar_status_spec.js
View file @
2db2a8a1
...
...
@@ -9,8 +9,8 @@ const mockAlert = mockAlerts[0];
describe
(
'
Alert Details Sidebar Status
'
,
()
=>
{
let
wrapper
;
const
findStatusDropdown
=
()
=>
wrapper
.
find
(
GlDropdown
);
const
findStatusLoadingIcon
=
()
=>
wrapper
.
find
(
GlLoadingIcon
);
const
findStatusDropdown
=
()
=>
wrapper
.
find
Component
(
GlDropdown
);
const
findStatusLoadingIcon
=
()
=>
wrapper
.
find
Component
(
GlLoadingIcon
);
const
findAlertStatus
=
()
=>
wrapper
.
findComponent
(
AlertStatus
);
const
findStatus
=
()
=>
wrapper
.
findByTestId
(
'
status
'
);
const
findSidebarIcon
=
()
=>
wrapper
.
findByTestId
(
'
status-icon
'
);
...
...
@@ -74,7 +74,8 @@ describe('Alert Details Sidebar Status', () => {
sidebarCollapsed
:
false
,
loading
:
false
,
});
await
findAlertStatus
().
vm
.
$emit
(
'
handle-updating
'
,
true
);
findAlertStatus
().
vm
.
$emit
(
'
handle-updating
'
,
true
);
await
wrapper
.
vm
.
$nextTick
();
expect
(
findStatusLoadingIcon
().
exists
()).
toBe
(
true
);
});
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment