Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
2dc51b6f
Commit
2dc51b6f
authored
Oct 01, 2019
by
Winnie Hellmann
Committed by
Mike Greiling
Oct 01, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Narrow down violation of promise/no-nesting ESLint rule
parent
6cae55a9
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
8 additions
and
1 deletion
+8
-1
.eslintrc.yml
.eslintrc.yml
+0
-1
app/assets/javascripts/ide/.eslintrc.yml
app/assets/javascripts/ide/.eslintrc.yml
+3
-0
ee/spec/frontend/ide/lib/mirror_spec.js
ee/spec/frontend/ide/lib/mirror_spec.js
+2
-0
spec/javascripts/create_cluster/.eslintrc.yml
spec/javascripts/create_cluster/.eslintrc.yml
+3
-0
No files found.
.eslintrc.yml
View file @
2dc51b6f
...
@@ -45,7 +45,6 @@ rules:
...
@@ -45,7 +45,6 @@ rules:
no-jquery/no-serialize
:
error
no-jquery/no-serialize
:
error
promise/always-return
:
off
promise/always-return
:
off
promise/no-callback-in-promise
:
off
promise/no-callback-in-promise
:
off
promise/no-nesting
:
off
overrides
:
overrides
:
files
:
files
:
-
'
**/spec/**/*'
-
'
**/spec/**/*'
...
...
app/assets/javascripts/ide/.eslintrc.yml
0 → 100644
View file @
2dc51b6f
rules
:
# https://gitlab.com/gitlab-org/gitlab/issues/33024
promise/no-nesting
:
off
ee/spec/frontend/ide/lib/mirror_spec.js
View file @
2dc51b6f
...
@@ -124,6 +124,8 @@ describe('ee/ide/lib/mirror', () => {
...
@@ -124,6 +124,8 @@ describe('ee/ide/lib/mirror', () => {
it
(
'
disconnects when connected again
'
,
()
=>
{
it
(
'
disconnects when connected again
'
,
()
=>
{
const
result
=
connection
const
result
=
connection
.
then
(()
=>
{
.
then
(()
=>
{
// https://gitlab.com/gitlab-org/gitlab/issues/33024
// eslint-disable-next-line promise/no-nesting
mirror
.
connect
(
TEST_PATH
).
catch
(()
=>
{});
mirror
.
connect
(
TEST_PATH
).
catch
(()
=>
{});
})
})
.
then
(()
=>
{
.
then
(()
=>
{
...
...
spec/javascripts/create_cluster/.eslintrc.yml
0 → 100644
View file @
2dc51b6f
rules
:
# https://gitlab.com/gitlab-org/gitlab/issues/33025
promise/no-nesting
:
off
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment