Merge branch 'jejacks0n/jobs-to-be-done' into 'master'

Jobs to be done experiment in first mile -- asking for objective [RUN ALL RSPEC] [RUN AS-IF-FOSS]

See merge request gitlab-org/gitlab!60038

app/experiments/application_experiment.rb

@@ -36,6 +36,10 @@ class ApplicationExperiment < Gitlab::Experiment # rubocop:disable Gitlab/Namesp
     @excluded = true
   end
 
+  def control_behavior
+    # define a default nil control behavior so we can omit it when not needed
+  end
+
   private
 
   def feature_flag_name

app/views/registrations/welcome/show.html.haml

@@ -25,6 +25,7 @@
               = f.text_field :other_role, class: 'form-control'
         = render_if_exists "registrations/welcome/setup_for_company", f: f
         = render 'devise/shared/email_opted_in', f: f
+        = render_if_exists "registrations/welcome/jobs_to_be_done", f: f
         .row
           .form-group.col-sm-12.gl-mb-0
             - if partial_exists? "registrations/welcome/button"

config/feature_flags/experiment/jobs_to_be_done.yml

+---
+name: jobs_to_be_done
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/60038
+rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/285564
+milestone: '13.12'
+type: experiment
+group: group::adoption
+default_enabled: false

ee/app/assets/javascripts/registrations/welcome/index.js

 import Vue from 'vue';
 import 'ee/registrations/welcome/other_role';
+import 'ee/registrations/welcome/jobs_to_be_done';
 import { parseBoolean } from '~/lib/utils/common_utils';
 import ProgressBar from '../components/progress_bar.vue';
 import { STEPS, SUBSCRIPTON_FLOW_STEPS, SIGNUP_ONBOARDING_FLOW_STEPS } from '../constants';

ee/app/assets/javascripts/registrations/welcome/jobs_to_be_done.js

+import { getExperimentContexts } from '~/experimentation/utils';
+import Tracking from '~/tracking';
+
+const select = document.querySelector('.js-jobs-to-be-done-dropdown');
+if (select) {
+  Tracking.enableFormTracking(
+    { fields: { whitelist: ['jobs_to_be_done', 'jobs_to_be_done_other'] } },
+    getExperimentContexts('jobs_to_be_done'),
+  );
+
+  select.addEventListener('change', () => {
+    const otherSelected = select.value === 'other';
+    document
+      .querySelector('.js-jobs-to-be-done-other-group')
+      .classList.toggle('hidden', !otherSelected);
+  });
+}

ee/app/controllers/registrations/groups_controller.rb

@@ -23,6 +23,8 @@ module Registrations
       @group = Groups::CreateService.new(current_user, group_params).execute
 
       if @group.persisted?
+        experiment(:jobs_to_be_done, user: current_user)
+          .track(:create_group, namespace: @group)
         create_successful_flow
       else
         render action: :new

ee/app/controllers/registrations/projects_controller.rb

@@ -33,6 +33,8 @@ module Registrations
 
         experiment(:registrations_group_invite, actor: current_user)
           .track(:signup_successful, property: @project.namespace_id.to_s)
+        experiment(:jobs_to_be_done, user: current_user)
+          .track(:create_project, project: @project)
 
         if helpers.in_trial_onboarding_flow?
           record_experiment_user(:trial_onboarding_issues, onboarding_context)

ee/app/views/registrations/welcome/_jobs_to_be_done.html.haml

+- experiment(:jobs_to_be_done, user: current_user) do |e|
+  - e.try do
+    .row
+      .form-group.col-sm-12
+        = label_tag :jobs_to_be_done, _("I'm signing up for GitLab because:")
+        = select_tag :jobs_to_be_done,
+                options_for_select([_('I want to learn the basics of Git'),
+                  _('I want to move my repository to GitLab from somewhere else'),
+                  _('I want to explore GitLab to see if it’s worth switching to'),
+                  _('I want to use GitLab CI with my existing repository'),
+                  _('I’m joining my team who’s already on GitLab'),
+                  [_('A different reason'), 'other']]),
+                include_blank: _('Please select...'), class: 'form-control js-jobs-to-be-done-dropdown'
+    .row
+      .form-group.col-sm-12.js-jobs-to-be-done-other-group.hidden
+        = label_tag :jobs_to_be_done_other, _('Why are you signing up? (Optional)')
+        = text_field_tag :jobs_to_be_done_other, '', class: 'form-control'

ee/spec/controllers/registrations/groups_controller_spec.rb

@@ -137,6 +137,17 @@ RSpec.describe Registrations::GroupsController do
           expect { subject }.to change { Group.count }.by(1)
         end
 
+        it 'tracks an event for the jobs_to_be_done experiment', :experiment do
+          stub_experiments(jobs_to_be_done: :candidate)
+
+          expect(experiment(:jobs_to_be_done)).to track(:create_group, namespace: an_instance_of(Group))
+            .on_next_instance
+            .for(:candidate)
+            .with_context(user: user)
+
+          subject
+        end
+
         context 'when the trial onboarding is active - apply_trial_for_trial_onboarding_flow' do
           let_it_be(:group) { create(:group) }
           let_it_be(:trial_onboarding_flow_params) { { trial_onboarding_flow: true, glm_source: 'about.gitlab.com', glm_content: 'content' } }

ee/spec/controllers/registrations/projects_controller_spec.rb

@@ -84,6 +84,17 @@ RSpec.describe Registrations::ProjectsController do
         expect(namespace.projects.find_by_name(s_('Learn GitLab'))).to be_import_finished
       end
 
+      it 'tracks an event for the jobs_to_be_done experiment', :experiment do
+        stub_experiments(jobs_to_be_done: :candidate)
+
+        expect(experiment(:jobs_to_be_done)).to track(:create_project, project: an_instance_of(Project))
+          .on_next_instance
+          .for(:candidate)
+          .with_context(user: user)
+
+        subject
+      end
+
       it 'tracks learn gitlab experiments' do
         allow_next_instance_of(::Projects::CreateService) do |service|
           allow(service).to receive(:execute).and_return(first_project)

ee/spec/features/registrations/welcome_spec.rb

@@ -5,12 +5,15 @@ require 'spec_helper'
 RSpec.describe 'Welcome screen', :js do
   let_it_be(:user) { create(:user) }
 
+  let(:experiments) { {} }
+
   context 'when on GitLab.com' do
     let(:user_has_memberships) { false }
     let(:in_subscription_flow) { false }
     let(:in_trial_flow) { false }
 
     before do
+      stub_experiments(experiments)
       allow(Gitlab).to receive(:com?).and_return(true)
       gitlab_sign_in(user)
       allow_any_instance_of(EE::WelcomeHelper).to receive(:user_has_memberships?).and_return(user_has_memberships)
@@ -50,6 +53,20 @@ RSpec.describe 'Welcome screen', :js do
       end
     end
 
+    context 'with the jobs_to_be_done experiment' do
+      let(:experiments) { { jobs_to_be_done: :candidate } }
+
+      it 'allows specifying other for the jobs_to_be_done experiment', :experiment do
+        expect(page).not_to have_content('Why are you signing up? (Optional)')
+
+        select 'A different reason', from: 'jobs_to_be_done'
+
+        expect(page).to have_content('Why are you signing up? (Optional)')
+
+        fill_in 'jobs_to_be_done_other', with: 'My reason'
+      end
+    end
+
     context 'email opt in' do
       it 'does not show the email opt in checkbox when setting up for a company' do
         expect(page).not_to have_selector('input[name="user[email_opted_in]', visible: true)

ee/spec/views/registrations/welcome/show.html.haml_spec.rb

@@ -6,8 +6,9 @@ RSpec.describe 'registrations/welcome/show' do
   using RSpec::Parameterized::TableSyntax
 
   describe 'forms and progress bar' do
-    let_it_be(:user) { User.new }
+    let_it_be(:user) { create(:user) }
     let_it_be(:user_other_role_details_enabled) { false }
+    let_it_be(:stubbed_experiments) { {} }
 
     before do
       allow(view).to receive(:current_user).and_return(user)
@@ -15,6 +16,7 @@ RSpec.describe 'registrations/welcome/show' do
       allow(view).to receive(:signup_onboarding_enabled?).and_return(signup_onboarding_enabled)
       allow(Gitlab).to receive(:com?).and_return(true)
       stub_feature_flags(user_other_role_details: user_other_role_details_enabled)
+      stub_experiments(stubbed_experiments)
 
       render
     end
@@ -55,6 +57,15 @@ RSpec.describe 'registrations/welcome/show' do
           is_expected.to have_selector('input[type="text"][name="user[other_role]"]')
         end
       end
+
+      context 'experiment(:jobs_to_be_done)' do
+        let_it_be(:stubbed_experiments) { { jobs_to_be_done: :candidate } }
+
+        it 'renders a select and text field for additional information' do
+          is_expected.to have_selector('select[name="jobs_to_be_done"]')
+          is_expected.to have_selector('input[name="jobs_to_be_done_other"]', visible: false)
+        end
+      end
     end
   end
 

locale/gitlab.pot

@@ -1394,6 +1394,9 @@ msgstr ""
 msgid "A description is required"
 msgstr ""
 
+msgid "A different reason"
+msgstr ""
+
 msgid "A file has been changed."
 msgstr ""
 
@@ -16420,9 +16423,24 @@ msgstr ""
 msgid "I have read and agree to the Let's Encrypt %{link_start}Terms of Service%{link_end} (PDF)"
 msgstr ""
 
+msgid "I want to explore GitLab to see if it’s worth switching to"
+msgstr ""
+
+msgid "I want to learn the basics of Git"
+msgstr ""
+
+msgid "I want to move my repository to GitLab from somewhere else"
+msgstr ""
+
+msgid "I want to use GitLab CI with my existing repository"
+msgstr ""
+
 msgid "I'd like to receive updates about GitLab via email"
 msgstr ""
 
+msgid "I'm signing up for GitLab because:"
+msgstr ""
+
 msgid "ID"
 msgstr ""
 
@@ -18435,6 +18453,9 @@ msgstr ""
 msgid "I’m familiar with the basics of DevOps."
 msgstr ""
 
+msgid "I’m joining my team who’s already on GitLab"
+msgstr ""
+
 msgid "I’m not familiar with the basics of DevOps."
 msgstr ""
 
@@ -24535,6 +24556,9 @@ msgstr ""
 msgid "Please select what should be included in each exported requirement."
 msgstr ""
 
+msgid "Please select..."
+msgstr ""
+
 msgid "Please set a new password before proceeding."
 msgstr ""
 
@@ -36503,6 +36527,9 @@ msgstr ""
 msgid "Who will be using this GitLab trial?"
 msgstr ""
 
+msgid "Why are you signing up? (Optional)"
+msgstr ""
+
 msgid "Wiki"
 msgstr ""
 

spec/experiments/application_experiment_spec.rb

@@ -25,6 +25,12 @@ RSpec.describe ApplicationExperiment, :experiment do
     described_class.new('namespaced/stub')
   end
 
+  it "doesn't raise an exception without a defined control" do
+    # because we have a default behavior defined
+
+    expect { experiment('namespaced/stub') { } }.not_to raise_error
+  end
+
   describe "enabled" do
     before do
       allow(subject).to receive(:enabled?).and_call_original

spec/views/registrations/welcome/show.html.haml_spec.rb

@@ -5,7 +5,7 @@ require 'spec_helper'
 RSpec.describe 'registrations/welcome/show' do
   let(:is_gitlab_com) { false }
 
-  let_it_be(:user) { User.new }
+  let_it_be(:user) { create(:user) }
 
   before do
     allow(view).to receive(:current_user).and_return(user)