Remove references for confidential issues from autocomplete

app/models/issue.rb

@@ -45,6 +45,7 @@ class Issue < ActiveRecord::Base
   scope :cared, ->(user) { where(assignee_id: user) }
   scope :open_for, ->(user) { opened.assigned_to(user) }
   scope :in_projects, ->(project_ids) { where(project_id: project_ids) }
+  scope :not_confidential, -> { where(confidential: false) }
 
   state_machine :state, initial: :opened do
     event :close do

app/services/projects/autocomplete_service.rb

@@ -5,7 +5,7 @@ module Projects
     end
 
     def issues
-      @project.issues.opened.select([:iid, :title])
+      @project.issues.not_confidential.opened.select([:iid, :title])
     end
 
     def merge_requests

spec/services/projects/autocomplete_service_spec.rb

+require 'spec_helper'
+
+describe Projects::AutocompleteService, services: true do
+  let(:project) { create(:empty_project, :public) }
+
+  subject(:autocomplete) { described_class.new(project) }
+
+  describe '#issues' do
+    it 'should not list confidential issues' do
+      issue = create(:issue, project: project)
+      create(:issue, :confidential, project: project)
+
+      expect(autocomplete.issues.map(&:iid)).to eq [issue.iid]
+    end
+  end
+end