Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
30df1808
Commit
30df1808
authored
Dec 23, 2020
by
Illya Klymov
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove deprecated `isEmpty` call
`@vue/test-utils` 1.x deprecated isEmpty call
parent
4ab9b3ea
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
5 additions
and
8 deletions
+5
-8
spec/frontend/jobs/components/job_sidebar_details_container_spec.js
...end/jobs/components/job_sidebar_details_container_spec.js
+2
-5
spec/frontend/releases/components/releases_pagination_graphql_spec.js
...d/releases/components/releases_pagination_graphql_spec.js
+1
-1
spec/frontend/vue_shared/security_reports/security_reports_app_spec.js
.../vue_shared/security_reports/security_reports_app_spec.js
+2
-2
No files found.
spec/frontend/jobs/components/job_sidebar_details_container_spec.js
View file @
30df1808
...
...
@@ -37,7 +37,7 @@ describe('Job Sidebar Details Container', () => {
it
(
'
should render an empty container
'
,
()
=>
{
createWrapper
();
expect
(
wrapper
.
isEmpty
()).
toBe
(
true
);
expect
(
wrapper
.
html
()).
toBe
(
''
);
});
});
...
...
@@ -55,7 +55,6 @@ describe('Job Sidebar Details Container', () => {
await
store
.
dispatch
(
'
receiveJobSuccess
'
,
{
[
detail
]:
job
[
detail
]
});
const
detailsRow
=
findAllDetailsRow
();
expect
(
wrapper
.
isEmpty
()).
toBe
(
false
);
expect
(
detailsRow
).
toHaveLength
(
1
);
expect
(
detailsRow
.
at
(
0
).
text
()).
toBe
(
value
);
});
...
...
@@ -65,7 +64,6 @@ describe('Job Sidebar Details Container', () => {
await
store
.
dispatch
(
'
receiveJobSuccess
'
,
{
tags
});
const
tagsComponent
=
findJobTags
();
expect
(
wrapper
.
isEmpty
()).
toBe
(
false
);
expect
(
tagsComponent
.
text
()).
toBe
(
'
Tags: tag
'
);
});
});
...
...
@@ -91,7 +89,7 @@ describe('Job Sidebar Details Container', () => {
await
store
.
dispatch
(
'
receiveJobSuccess
'
,
{
metadata
});
const
detailsRow
=
findAllDetailsRow
();
expect
(
wrapper
.
isEmpty
()).
toBe
(
true
);
expect
(
wrapper
.
html
()).
toBe
(
''
);
expect
(
detailsRow
.
exists
()).
toBe
(
false
);
});
...
...
@@ -100,7 +98,6 @@ describe('Job Sidebar Details Container', () => {
await
store
.
dispatch
(
'
receiveJobSuccess
'
,
{
metadata
});
const
detailsRow
=
findAllDetailsRow
();
expect
(
wrapper
.
isEmpty
()).
toBe
(
false
);
expect
(
detailsRow
).
toHaveLength
(
1
);
expect
(
detailsRow
.
at
(
0
).
text
()).
toBe
(
'
Timeout: 1m 40s
'
);
});
...
...
spec/frontend/releases/components/releases_pagination_graphql_spec.js
View file @
30df1808
...
...
@@ -72,7 +72,7 @@ describe('~/releases/components/releases_pagination_graphql.vue', () => {
});
it
(
'
does not render anything
'
,
()
=>
{
expect
(
wrapper
.
isEmpty
()).
toBe
(
true
);
expect
(
wrapper
.
html
()).
toBe
(
''
);
});
});
...
...
spec/frontend/vue_shared/security_reports/security_reports_app_spec.js
View file @
30df1808
...
...
@@ -371,7 +371,7 @@ describe('Security reports app', () => {
// TODO: Remove this assertion as part of
// https://gitlab.com/gitlab-org/gitlab/-/issues/273431
it
(
'
initially renders nothing
'
,
()
=>
{
expect
(
wrapper
.
isEmpty
()).
toBe
(
true
);
expect
(
wrapper
.
html
()).
toBe
(
''
);
});
});
...
...
@@ -415,7 +415,7 @@ describe('Security reports app', () => {
// TODO: Remove this assertion as part of
// https://gitlab.com/gitlab-org/gitlab/-/issues/273431
it
(
'
renders nothing
'
,
()
=>
{
expect
(
wrapper
.
isEmpty
()).
toBe
(
true
);
expect
(
wrapper
.
html
()).
toBe
(
''
);
});
});
});
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment