Commit 30f8e982 authored by Timothy Andrew's avatar Timothy Andrew

Fix push/merge access level models.

The models were incorrectly merged (this would have been avoided if !927
was merged in, but that MR is still review) leading to a few spec failures.
parent 0b64b73a
...@@ -16,4 +16,12 @@ class ProtectedBranch::MergeAccessLevel < ActiveRecord::Base ...@@ -16,4 +16,12 @@ class ProtectedBranch::MergeAccessLevel < ActiveRecord::Base
Gitlab::Access::DEVELOPER => "Developers + Masters" Gitlab::Access::DEVELOPER => "Developers + Masters"
}.with_indifferent_access }.with_indifferent_access
end end
def check_access(user)
return true if user.is_admin?
return user.id == self.user_id if self.user.present?
return group.users.exists?(user.id) if self.group.present?
super
end
end end
...@@ -21,6 +21,7 @@ class ProtectedBranch::PushAccessLevel < ActiveRecord::Base ...@@ -21,6 +21,7 @@ class ProtectedBranch::PushAccessLevel < ActiveRecord::Base
def check_access(user) def check_access(user)
return false if access_level == Gitlab::Access::NO_ACCESS return false if access_level == Gitlab::Access::NO_ACCESS
return true if user.is_admin?
return user.id == self.user_id if self.user.present? return user.id == self.user_id if self.user.present?
return group.users.exists?(user.id) if self.group.present? return group.users.exists?(user.id) if self.group.present?
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment