Run least expensive method first - has_metrics?

Success is relatively cheap compared to prometheus_adapter which can invoke deployment_platform which does a lot of work

Run least expensive method first - has_metrics?
Success is relatively cheap compared to prometheus_adapter which can invoke deployment_platform which does a lot of work
3129cbd5 · Thong Kuah · 65b6a37f · 3129cbd5
Commit 3129cbd5 authored Jun 20, 2019 by Thong Kuah
Show whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

app/models/deployment.rb app/models/deployment.rb +1 -1

No files found.
--- a/app/models/deployment.rb
+++ b/app/models/deployment.rb
@@ -179,7 +179,7 @@ class Deployment < ApplicationRecord
  end
  def has_metrics?
-    prometheus_adapter&.can_query? && success?
+    success? && prometheus_adapter&.can_query?
  end
  def metrics