Run least expensive method first - #has_terminals?

available? is much cheaper than deployment_platform

Run least expensive method first - #has_terminals?
available? is much cheaper than deployment_platform
65b6a37f · Thong Kuah · e99a55ff · 65b6a37f
Commit 65b6a37f authored Jun 19, 2019 by Thong Kuah
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

app/models/environment.rb app/models/environment.rb +1 -1

No files found.
--- a/app/models/environment.rb
+++ b/app/models/environment.rb
@@ -155,7 +155,7 @@ class Environment < ApplicationRecord
  end

  def has_terminals?
-    deployment_platform.present? && available? && last_deployment.present?
+    available? && deployment_platform.present? && last_deployment.present?
  end

  def terminals