Merge branch 'pl-validate-issue-type' into 'master'

Prevent users from assigning an invalid issue type to new issues

See merge request gitlab-org/gitlab!69106

app/services/issues/base_service.rb

@@ -84,7 +84,8 @@ module Issues
 
     # @param object [Issue, Project]
     def issue_type_allowed?(object)
-      can?(current_user, :"create_#{params[:issue_type]}", object)
+      WorkItem::Type.base_types.key?(params[:issue_type]) &&
+        can?(current_user, :"create_#{params[:issue_type]}", object)
     end
 
     # @param issue [Issue]

spec/services/issues/build_service_spec.rb

@@ -183,8 +183,8 @@ RSpec.describe Issues::BuildService do
           expect(issue).to be_incident
         end
 
-        it 'cannot set invalid type' do
-          issue = build_issue(issue_type: 'invalid type')
+        it 'cannot set invalid issue type' do
+          issue = build_issue(issue_type: 'project')
 
           expect(issue).to be_issue
         end