Improve migrations readability

db/migrate/20170118194941_convert_application_settings_repository_size_limit_to_bytes.rb

@@ -10,14 +10,16 @@ class ConvertApplicationSettingsRepositorySizeLimitToBytes < ActiveRecord::Migra
       add_column :application_settings, :repository_size_limit, :integer, default: 0, limit: 8
     end
 
-    bigint_expression = if Gitlab::Database.postgresql?
-                          'repository_size_limit_mb::bigint * 1024 * 1024'
-                        else
-                          'repository_size_limit_mb * 1024 * 1024'
-                        end
+    bigint_string = if Gitlab::Database.postgresql?
+                      'repository_size_limit_mb::bigint * 1024 * 1024'
+                    else
+                      'repository_size_limit_mb * 1024 * 1024'
+                    end
+
+    sql_expression = Arel::Nodes::SqlLiteral.new(bigint_string)
 
     connection.transaction do
-      update_column_in_batches(:application_settings, :repository_size_limit, Arel::Nodes::SqlLiteral.new(bigint_expression)) do |t, query|
+      update_column_in_batches(:application_settings, :repository_size_limit, sql_expression) do |t, query|
         query.where(t[:repository_size_limit_mb].not_eq(nil))
       end
 
@@ -31,8 +33,10 @@ class ConvertApplicationSettingsRepositorySizeLimitToBytes < ActiveRecord::Migra
       add_column :application_settings, :repository_size_limit, :integer, default: 0, limit: nil
     end
 
+    sql_expression = Arel::Nodes::SqlLiteral.new('repository_size_limit_bytes / 1024 / 1024')
+
     connection.transaction do
-      update_column_in_batches(:application_settings, :repository_size_limit, Arel::Nodes::SqlLiteral.new('repository_size_limit_bytes / 1024 / 1024')) do |t, query|
+      update_column_in_batches(:application_settings, :repository_size_limit, sql_expression) do |t, query|
         query.where(t[:repository_size_limit_bytes].not_eq(nil))
       end
 

db/migrate/20170118200338_convert_projects_repository_size_limit_to_bytes.rb

@@ -13,14 +13,16 @@ class ConvertProjectsRepositorySizeLimitToBytes < ActiveRecord::Migration
       add_column :projects, :repository_size_limit, :integer, limit: 8
     end
 
-    bigint_expression = if Gitlab::Database.postgresql?
-                          'repository_size_limit_mb::bigint * 1024 * 1024'
-                        else
-                          'repository_size_limit_mb * 1024 * 1024'
-                        end
+    bigint_string = if Gitlab::Database.postgresql?
+                      'repository_size_limit_mb::bigint * 1024 * 1024'
+                    else
+                      'repository_size_limit_mb * 1024 * 1024'
+                    end
+
+    sql_expression = Arel::Nodes::SqlLiteral.new(bigint_string)
 
     connection.transaction do
-      update_column_in_batches(:projects, :repository_size_limit, Arel::Nodes::SqlLiteral.new(bigint_expression)) do |t, query|
+      update_column_in_batches(:projects, :repository_size_limit, sql_expression) do |t, query|
         query.where(t[:repository_size_limit_mb].not_eq(nil))
       end
 
@@ -34,8 +36,10 @@ class ConvertProjectsRepositorySizeLimitToBytes < ActiveRecord::Migration
       add_column :projects, :repository_size_limit, :integer, limit: nil
     end
 
+    sql_expression = Arel::Nodes::SqlLiteral.new('repository_size_limit_bytes / 1024 / 1024')
+
     connection.transaction do
-      update_column_in_batches(:projects, :repository_size_limit, Arel::Nodes::SqlLiteral.new('repository_size_limit_bytes / 1024 / 1024')) do |t, query|
+      update_column_in_batches(:projects, :repository_size_limit, sql_expression) do |t, query|
         query.where(t[:repository_size_limit_bytes].not_eq(nil))
       end
 

db/migrate/20170118200412_convert_namespaces_repository_size_limit_to_bytes.rb

@@ -13,14 +13,16 @@ class ConvertNamespacesRepositorySizeLimitToBytes < ActiveRecord::Migration
       add_column :namespaces, :repository_size_limit, :integer, limit: 8
     end
 
-    bigint_expression = if Gitlab::Database.postgresql?
-                          'repository_size_limit_mb::bigint * 1024 * 1024'
-                        else
-                          'repository_size_limit_mb * 1024 * 1024'
-                        end
+    bigint_string = if Gitlab::Database.postgresql?
+                      'repository_size_limit_mb::bigint * 1024 * 1024'
+                    else
+                      'repository_size_limit_mb * 1024 * 1024'
+                    end
+
+    sql_expression = Arel::Nodes::SqlLiteral.new(bigint_string)
 
     connection.transaction do
-      update_column_in_batches(:namespaces, :repository_size_limit, Arel::Nodes::SqlLiteral.new(bigint_expression)) do |t, query|
+      update_column_in_batches(:namespaces, :repository_size_limit, sql_expression) do |t, query|
         query.where(t[:repository_size_limit_mb].not_eq(nil))
       end
 
@@ -34,8 +36,10 @@ class ConvertNamespacesRepositorySizeLimitToBytes < ActiveRecord::Migration
       add_column :namespaces, :repository_size_limit, :integer, limit: nil
     end
 
+    sql_expression = Arel::Nodes::SqlLiteral.new('repository_size_limit_bytes / 1024 / 1024')
+
     connection.transaction do
-      update_column_in_batches(:namespaces, :repository_size_limit, Arel::Nodes::SqlLiteral.new('repository_size_limit_bytes / 1024 / 1024')) do |t, query|
+      update_column_in_batches(:namespaces, :repository_size_limit, sql_expression) do |t, query|
         query.where(t[:repository_size_limit_bytes].not_eq(nil))
       end