Enable reorder_designs feature by default

app/graphql/mutations/design_management/move.rb

@@ -21,7 +21,7 @@ module Mutations
             description: "The current state of the collection"
 
       def ready(*)
-        raise ::Gitlab::Graphql::Errors::ResourceNotAvailable unless ::Feature.enabled?(:reorder_designs)
+        raise ::Gitlab::Graphql::Errors::ResourceNotAvailable unless ::Feature.enabled?(:reorder_designs, default_enabled: true)
       end
 
       def resolve(**args)

app/models/design_management/design.rb

@@ -82,7 +82,7 @@ module DesignManagement
     scope :ordered, -> (project) do
       # TODO: Always order by relative position after the feature flag is removed
       # https://gitlab.com/gitlab-org/gitlab/-/issues/34382
-      if Feature.enabled?(:reorder_designs, project)
+      if Feature.enabled?(:reorder_designs, project, default_enabled: true)
         # We need to additionally sort by `id` to support keyset pagination.
         # See https://gitlab.com/gitlab-org/gitlab/-/merge_requests/17788/diffs#note_230875678
         order(:relative_position, :id)

app/policies/project_policy.rb

@@ -103,7 +103,7 @@ class ProjectPolicy < BasePolicy
 
   with_scope :subject
   condition(:moving_designs_disabled) do
-    !::Feature.enabled?(:reorder_designs, @subject)
+    !::Feature.enabled?(:reorder_designs, @subject, default_enabled: true)
   end
 
   with_scope :subject

app/services/design_management/move_designs_service.rb

@@ -13,7 +13,7 @@ module DesignManagement
 
     def execute
       return error(:no_focus) unless current_design.present?
-      return error(:cannot_move) unless ::Feature.enabled?(:reorder_designs, project)
+      return error(:cannot_move) unless ::Feature.enabled?(:reorder_designs, project, default_enabled: true)
       return error(:cannot_move) unless current_user.can?(:move_design, current_design)
       return error(:no_neighbors) unless neighbors.present?
       return error(:not_distinct) unless all_distinct?

changelogs/unreleased/reorder-designs-fixes.yml

+---
+title: Enable reorder_designs feature by default
+merge_request: 39555
+author:
+type: changed

config/feature_flags/development/reorder_designs.yml

@@ -4,4 +4,4 @@ introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/37835
 rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/232992
 group: group::knowledge
 type: development
-default_enabled: false
+default_enabled: true