Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
359cd7b3
Commit
359cd7b3
authored
Oct 28, 2021
by
Jiaan Louw
Committed by
Kati Paizee
Oct 28, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Update JiHu review docs for reviewers
parent
b148b97b
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
8 additions
and
0 deletions
+8
-0
doc/development/jh_features_review.md
doc/development/jh_features_review.md
+8
-0
No files found.
doc/development/jh_features_review.md
View file @
359cd7b3
...
...
@@ -23,6 +23,14 @@ We have two kinds of changes related to JH:
If needed, review the corresponding JH merge request located at
[
JH repository
](
https://gitlab.com/gitlab-jh/gitlab
)
## When to merge files to the GitLab Inc. repository
Files that are added to the
`gitlab-jh`
repository outside of
`jh/`
must be mirrored in the GitLab Inc. repository.
If code that is added to the GitLab Inc. repository references (for example,
`render_if_exists`
) any
`gitlab-jh`
file that does not
exist in the GitLab Inc. codebase, add a comment with a link to the JiHu merge request or file. This is to prevent
the reference from being misidentified as a missing partial and subsequently deleted in the
`gitlab`
codebase.
## Process overview
See the
[
merge request process
](
https://about.gitlab.com/handbook/ceo/chief-of-staff-team/jihu-support/#merge-request-process
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment