Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
370ca918
Commit
370ca918
authored
Apr 26, 2021
by
Abdul Wadood
Committed by
Kerri Miller
Apr 26, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix RSpec/EmptyLineAfterFinalLetItBe for ee/spec/services/projects
parent
3bc07e26
Changes
8
Hide whitespace changes
Inline
Side-by-side
Showing
8 changed files
with
12 additions
and
6 deletions
+12
-6
.rubocop_manual_todo.yml
.rubocop_manual_todo.yml
+0
-6
ee/changelogs/unreleased/rspec-empty-lines-after-letitbe-ee-spec-projects.yml
...ased/rspec-empty-lines-after-letitbe-ee-spec-projects.yml
+5
-0
ee/spec/services/projects/after_rename_service_spec.rb
ee/spec/services/projects/after_rename_service_spec.rb
+1
-0
ee/spec/services/projects/alerting/notify_service_spec.rb
ee/spec/services/projects/alerting/notify_service_spec.rb
+2
-0
ee/spec/services/projects/destroy_service_spec.rb
ee/spec/services/projects/destroy_service_spec.rb
+1
-0
ee/spec/services/projects/gitlab_projects_import_service_spec.rb
.../services/projects/gitlab_projects_import_service_spec.rb
+1
-0
ee/spec/services/projects/import_export/export_service_spec.rb
...ec/services/projects/import_export/export_service_spec.rb
+1
-0
ee/spec/services/projects/transfer_service_spec.rb
ee/spec/services/projects/transfer_service_spec.rb
+1
-0
No files found.
.rubocop_manual_todo.yml
View file @
370ca918
...
@@ -614,12 +614,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
...
@@ -614,12 +614,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
-
ee/spec/services/merge_trains/refresh_service_spec.rb
-
ee/spec/services/merge_trains/refresh_service_spec.rb
-
ee/spec/services/personal_access_tokens/create_service_audit_log_spec.rb
-
ee/spec/services/personal_access_tokens/create_service_audit_log_spec.rb
-
ee/spec/services/personal_access_tokens/groups/update_lifetime_service_spec.rb
-
ee/spec/services/personal_access_tokens/groups/update_lifetime_service_spec.rb
-
ee/spec/services/projects/after_rename_service_spec.rb
-
ee/spec/services/projects/alerting/notify_service_spec.rb
-
ee/spec/services/projects/destroy_service_spec.rb
-
ee/spec/services/projects/gitlab_projects_import_service_spec.rb
-
ee/spec/services/projects/import_export/export_service_spec.rb
-
ee/spec/services/projects/transfer_service_spec.rb
-
ee/spec/services/push_rules/create_or_update_service_spec.rb
-
ee/spec/services/push_rules/create_or_update_service_spec.rb
-
ee/spec/services/quality_management/test_cases/create_service_spec.rb
-
ee/spec/services/quality_management/test_cases/create_service_spec.rb
-
ee/spec/services/quick_actions/interpret_service_spec.rb
-
ee/spec/services/quick_actions/interpret_service_spec.rb
...
...
ee/changelogs/unreleased/rspec-empty-lines-after-letitbe-ee-spec-projects.yml
0 → 100644
View file @
370ca918
---
title
:
Fix RSpec/EmptyLineAfterFinalLetItBe rubocop offenses in ee/spec/services/projects
merge_request
:
58330
author
:
Abdul Wadood @abdulwd
type
:
fixed
ee/spec/services/projects/after_rename_service_spec.rb
View file @
370ca918
...
@@ -9,6 +9,7 @@ RSpec.describe Projects::AfterRenameService do
...
@@ -9,6 +9,7 @@ RSpec.describe Projects::AfterRenameService do
context
'when running on a primary node'
do
context
'when running on a primary node'
do
let_it_be
(
:primary
)
{
create
(
:geo_node
,
:primary
)
}
let_it_be
(
:primary
)
{
create
(
:geo_node
,
:primary
)
}
let_it_be
(
:secondary
)
{
create
(
:geo_node
)
}
let_it_be
(
:secondary
)
{
create
(
:geo_node
)
}
let
(
:project
)
{
create
(
:project
,
:repository
,
:legacy_storage
)
}
let
(
:project
)
{
create
(
:project
,
:repository
,
:legacy_storage
)
}
let!
(
:path_before_rename
)
{
project
.
path
}
let!
(
:path_before_rename
)
{
project
.
path
}
let!
(
:full_path_before_rename
)
{
project
.
full_path
}
let!
(
:full_path_before_rename
)
{
project
.
full_path
}
...
...
ee/spec/services/projects/alerting/notify_service_spec.rb
View file @
370ca918
...
@@ -7,6 +7,7 @@ RSpec.describe Projects::Alerting::NotifyService do
...
@@ -7,6 +7,7 @@ RSpec.describe Projects::Alerting::NotifyService do
describe
'#execute'
do
describe
'#execute'
do
let_it_be
(
:integration
)
{
create
(
:alert_management_http_integration
,
project:
project
)
}
let_it_be
(
:integration
)
{
create
(
:alert_management_http_integration
,
project:
project
)
}
let
(
:service
)
{
described_class
.
new
(
project
,
payload
)
}
let
(
:service
)
{
described_class
.
new
(
project
,
payload
)
}
let
(
:token
)
{
integration
.
token
}
let
(
:token
)
{
integration
.
token
}
let
(
:payload
)
do
let
(
:payload
)
do
...
@@ -68,6 +69,7 @@ RSpec.describe Projects::Alerting::NotifyService do
...
@@ -68,6 +69,7 @@ RSpec.describe Projects::Alerting::NotifyService do
let_it_be
(
:schedule
)
{
create
(
:incident_management_oncall_schedule
,
project:
project
)
}
let_it_be
(
:schedule
)
{
create
(
:incident_management_oncall_schedule
,
project:
project
)
}
let_it_be
(
:rotation
)
{
create
(
:incident_management_oncall_rotation
,
schedule:
schedule
)
}
let_it_be
(
:rotation
)
{
create
(
:incident_management_oncall_rotation
,
schedule:
schedule
)
}
let_it_be
(
:participant
)
{
create
(
:incident_management_oncall_participant
,
:with_developer_access
,
rotation:
rotation
)
}
let_it_be
(
:participant
)
{
create
(
:incident_management_oncall_participant
,
:with_developer_access
,
rotation:
rotation
)
}
let
(
:payload
)
{
{
'fingerprint'
=>
'fingerprint'
}
}
let
(
:payload
)
{
{
'fingerprint'
=>
'fingerprint'
}
}
let
(
:resolving_payload
)
{
{
'fingerprint'
=>
'fingerprint'
,
"end_time"
:
Time
.
current
.
iso8601
}
}
let
(
:resolving_payload
)
{
{
'fingerprint'
=>
'fingerprint'
,
"end_time"
:
Time
.
current
.
iso8601
}
}
let
(
:users
)
{
[
participant
.
user
]
}
let
(
:users
)
{
[
participant
.
user
]
}
...
...
ee/spec/services/projects/destroy_service_spec.rb
View file @
370ca918
...
@@ -23,6 +23,7 @@ RSpec.describe Projects::DestroyService do
...
@@ -23,6 +23,7 @@ RSpec.describe Projects::DestroyService do
context
'when project is a mirror'
do
context
'when project is a mirror'
do
let
(
:max_capacity
)
{
Gitlab
::
CurrentSettings
.
mirror_max_capacity
}
let
(
:max_capacity
)
{
Gitlab
::
CurrentSettings
.
mirror_max_capacity
}
let_it_be
(
:project_mirror
)
{
create
(
:project
,
:mirror
,
:repository
,
:import_scheduled
)
}
let_it_be
(
:project_mirror
)
{
create
(
:project
,
:mirror
,
:repository
,
:import_scheduled
)
}
let
(
:result
)
{
described_class
.
new
(
project_mirror
,
project_mirror
.
owner
,
{}).
execute
}
let
(
:result
)
{
described_class
.
new
(
project_mirror
,
project_mirror
.
owner
,
{}).
execute
}
before
do
before
do
...
...
ee/spec/services/projects/gitlab_projects_import_service_spec.rb
View file @
370ca918
...
@@ -4,6 +4,7 @@ require 'spec_helper'
...
@@ -4,6 +4,7 @@ require 'spec_helper'
RSpec
.
describe
Projects
::
GitlabProjectsImportService
do
RSpec
.
describe
Projects
::
GitlabProjectsImportService
do
let_it_be
(
:namespace
)
{
create
(
:namespace
)
}
let_it_be
(
:namespace
)
{
create
(
:namespace
)
}
let
(
:path
)
{
'test-path'
}
let
(
:path
)
{
'test-path'
}
let
(
:custom_template
)
{
create
(
:project
)
}
let
(
:custom_template
)
{
create
(
:project
)
}
let
(
:overwrite
)
{
false
}
let
(
:overwrite
)
{
false
}
...
...
ee/spec/services/projects/import_export/export_service_spec.rb
View file @
370ca918
...
@@ -9,6 +9,7 @@ RSpec.describe Projects::ImportExport::ExportService do
...
@@ -9,6 +9,7 @@ RSpec.describe Projects::ImportExport::ExportService do
let_it_be
(
:subgroup
)
{
create
(
:group
,
:private
,
parent:
group
)
}
let_it_be
(
:subgroup
)
{
create
(
:group
,
:private
,
parent:
group
)
}
let_it_be
(
:project_template
)
{
create
(
:project
,
group:
subgroup
)
}
let_it_be
(
:project_template
)
{
create
(
:project
,
group:
subgroup
)
}
let_it_be
(
:user
)
{
create
(
:user
)
}
let_it_be
(
:user
)
{
create
(
:user
)
}
let
(
:shared
)
{
project_template
.
import_export_shared
}
let
(
:shared
)
{
project_template
.
import_export_shared
}
subject
{
described_class
.
new
(
project_template
,
user
).
execute
}
subject
{
described_class
.
new
(
project_template
,
user
).
execute
}
...
...
ee/spec/services/projects/transfer_service_spec.rb
View file @
370ca918
...
@@ -7,6 +7,7 @@ RSpec.describe Projects::TransferService do
...
@@ -7,6 +7,7 @@ RSpec.describe Projects::TransferService do
let_it_be
(
:user
)
{
create
(
:user
)
}
let_it_be
(
:user
)
{
create
(
:user
)
}
let_it_be
(
:group
)
{
create
(
:group
,
:public
)
}
let_it_be
(
:group
)
{
create
(
:group
,
:public
)
}
let
(
:project
)
{
create
(
:project
,
:repository
,
:public
,
:legacy_storage
,
namespace:
user
.
namespace
)
}
let
(
:project
)
{
create
(
:project
,
:repository
,
:public
,
:legacy_storage
,
namespace:
user
.
namespace
)
}
subject
{
described_class
.
new
(
project
,
user
)
}
subject
{
described_class
.
new
(
project
,
user
)
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment