Merge branch '21067-reduce-SQL-calls-when-creating-SystemNotes' into 'master'

Reduce number of SQL queries on SystemNote create

See merge request gitlab-org/gitlab!59102

app/services/system_notes/base_service.rb

@@ -13,10 +13,10 @@ module SystemNotes
     protected
 
     def create_note(note_summary)
-      note = Note.create(note_summary.note.merge(system: true))
-      note.system_note_metadata = SystemNoteMetadata.new(note_summary.metadata) if note_summary.metadata?
+      note_params = note_summary.note.merge(system: true)
+      note_params[:system_note_metadata] = SystemNoteMetadata.new(note_summary.metadata) if note_summary.metadata?
 
-      note
+      Note.create(note_params)
     end
 
     def content_tag(*args)

changelogs/unreleased/21067-reduce-SQL-calls-when-creating-SystemNotes.yml

+---
+title: Reduce number of SQL queries when creating SystemNotes
+merge_request: 59102
+author:
+type: performance