Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
392ca150
Commit
392ca150
authored
Mar 19, 2020
by
Natalia Tepluhina
Committed by
Martin Wortschack
Mar 19, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Resolve "Improve format support message in issue design"
parent
5ea31b5a
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
7 additions
and
4 deletions
+7
-4
changelogs/unreleased/210339-improve-format-support-message-in-issue-design.yml
...210339-improve-format-support-message-in-issue-design.yml
+5
-0
ee/app/assets/javascripts/design_management/utils/cache_update.js
...ssets/javascripts/design_management/utils/cache_update.js
+1
-2
ee/spec/frontend/design_management/utils/cache_update_spec.js
...pec/frontend/design_management/utils/cache_update_spec.js
+1
-2
No files found.
changelogs/unreleased/210339-improve-format-support-message-in-issue-design.yml
0 → 100644
View file @
392ca150
---
title
:
Resolve Improve format support message in issue design
merge_request
:
27409
author
:
type
:
fixed
ee/app/assets/javascripts/design_management/utils/cache_update.js
View file @
392ca150
...
...
@@ -4,7 +4,6 @@ import {
ADD_IMAGE_DIFF_NOTE_ERROR
,
UPDATE_IMAGE_DIFF_NOTE_ERROR
,
ADD_DISCUSSION_COMMENT_ERROR
,
UPLOAD_DESIGN_ERROR
,
designDeletionError
,
}
from
'
./error_messages
'
;
...
...
@@ -292,7 +291,7 @@ export const updateStoreAfterUpdateImageDiffNote = (store, data, query, queryVar
export
const
updateStoreAfterUploadDesign
=
(
store
,
data
,
query
)
=>
{
if
(
hasErrors
(
data
))
{
onError
(
data
,
UPLOAD_DESIGN_ERROR
);
onError
(
data
,
data
.
errors
[
0
]
);
}
else
{
addNewDesignToStore
(
store
,
data
,
query
);
}
...
...
ee/spec/frontend/design_management/utils/cache_update_spec.js
View file @
392ca150
...
...
@@ -10,7 +10,6 @@ import {
designDeletionError
,
ADD_DISCUSSION_COMMENT_ERROR
,
ADD_IMAGE_DIFF_NOTE_ERROR
,
UPLOAD_DESIGN_ERROR
,
UPDATE_IMAGE_DIFF_NOTE_ERROR
,
}
from
'
ee/design_management/utils/error_messages
'
;
import
design
from
'
../mock_data/design
'
;
...
...
@@ -33,7 +32,7 @@ describe('Design Management cache update', () => {
${
'
updateStoreAfterDesignsDelete
'
}
|
${
updateStoreAfterDesignsDelete
}
|
${
designDeletionError
({
singular
:
true
})}
|
${[[
design
]]}
${
'
updateStoreAfterAddDiscussionComment
'
}
|
${
updateStoreAfterAddDiscussionComment
}
|
${
ADD_DISCUSSION_COMMENT_ERROR
}
|
${[]}
${
'
updateStoreAfterAddImageDiffNote
'
}
|
${
updateStoreAfterAddImageDiffNote
}
|
${
ADD_IMAGE_DIFF_NOTE_ERROR
}
|
${[]}
${
'
updateStoreAfterUploadDesign
'
}
|
${
updateStoreAfterUploadDesign
}
|
${
UPLOAD_DESIGN_ERROR
}
|
${[]}
${
'
updateStoreAfterUploadDesign
'
}
|
${
updateStoreAfterUploadDesign
}
|
${
mockErrors
[
0
]}
|
${[]}
${
'
updateStoreAfterUpdateImageDiffNote
'
}
|
${
updateStoreAfterUpdateImageDiffNote
}
|
${
UPDATE_IMAGE_DIFF_NOTE_ERROR
}
|
${[]}
`
(
'
$fnName handles errors in response
'
,
({
subject
,
extraArgs
,
errorMessage
})
=>
{
expect
(
createFlash
).
not
.
toHaveBeenCalled
();
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment