Update help popover icon

This change updates the help popover icon to match our design system.

Changelog: changed

app/assets/javascripts/vue_shared/components/help_popover.vue

@@ -25,7 +25,7 @@ export default {
 </script>
 <template>
   <span>
-    <gl-button ref="popoverTrigger" variant="link" icon="question" :aria-label="__('Help')" />
+    <gl-button ref="popoverTrigger" variant="link" icon="question-o" :aria-label="__('Help')" />
     <gl-popover :target="() => $refs.popoverTrigger.$el" v-bind="options">
       <template v-if="options.title" #title>
         <span v-safe-html="options.title"></span>

spec/frontend/reports/codequality_report/grouped_codequality_reports_app_spec.js

@@ -135,7 +135,7 @@ describe('Grouped code quality reports app', () => {
     });
 
     it('does not render a help icon', () => {
-      expect(findWidget().find('[data-testid="question-icon"]').exists()).toBe(false);
+      expect(findWidget().find('[data-testid="question-o-icon"]').exists()).toBe(false);
     });
 
     describe('when base report was not found', () => {
@@ -144,7 +144,7 @@ describe('Grouped code quality reports app', () => {
       });
 
       it('renders a help icon with more information', () => {
-        expect(findWidget().find('[data-testid="question-icon"]').exists()).toBe(true);
+        expect(findWidget().find('[data-testid="question-o-icon"]').exists()).toBe(true);
       });
     });
   });

spec/frontend/vue_shared/components/help_popover_spec.js

@@ -34,7 +34,7 @@ describe('HelpPopover', () => {
 
     it('renders a link button with an icon question', () => {
       expect(findQuestionButton().props()).toMatchObject({
-        icon: 'question',
+        icon: 'question-o',
         variant: 'link',
       });
     });