Added permissions check to design management

ee/app/assets/javascripts/design_management/components/upload/form.vue

@@ -11,6 +11,10 @@ export default {
       type: Boolean,
       required: true,
     },
+    canUploadDesign: {
+      type: Boolean,
+      required: true,
+    },
   },
   methods: {
     openFileUpload() {
@@ -27,6 +31,7 @@ export default {
   <header class="row-content-block border-top-0 p-2 d-flex">
     <div>
       <gl-button
+        v-if="canUploadDesign"
         :disabled="isSaving"
         variant="primary"
         class="btn-inverted"

ee/app/assets/javascripts/design_management/graphql.js

@@ -30,6 +30,7 @@ const designsStore = [
 const defaultClient = createDefaultClient({
   defaults: {
     designs: designsStore,
+    canUploadDesign: true,
   },
   resolvers: {
     Query: {

ee/app/assets/javascripts/design_management/pages/index.vue

@@ -6,6 +6,7 @@ import DesignList from '../components/list/index.vue';
 import UploadForm from '../components/upload/form.vue';
 import allDesignsQuery from '../queries/allDesigns.graphql';
 import uploadDesignQuery from '../queries/uploadDesign.graphql';
+import canUploadDesignPermission from '../queries/canUploadDesignPermission.graphql';
 
 export default {
   components: {
@@ -20,10 +21,14 @@ export default {
         this.error = true;
       },
     },
+    canUploadDesign: {
+      query: canUploadDesignPermission,
+    },
   },
   data() {
     return {
       designs: [],
+      canUploadDesign: false,
       error: false,
       isSaving: false,
     };
@@ -35,6 +40,8 @@ export default {
   },
   methods: {
     onUploadDesign(files) {
+      if (!this.canUploadDesign) return null;
+
       const optimisticResponse = [...files].map(file => ({
         __typename: 'Design',
         id: -1,
@@ -80,7 +87,12 @@ export default {
 
 <template>
   <div>
-    <upload-form :is-saving="isSaving" @upload="onUploadDesign" />
+    <upload-form
+      v-if="canUploadDesign"
+      :can-upload-design="canUploadDesign"
+      :is-saving="isSaving"
+      @upload="onUploadDesign"
+    />
     <div class="mt-4">
       <gl-loading-icon v-if="isLoading" size="md" />
       <div v-else-if="error" class="alert alert-danger">

ee/app/assets/javascripts/design_management/queries/canUploadDesignPermission.graphql

+query canUploadDesign {
+  canUploadDesign @client
+}

ee/app/assets/javascripts/pages/projects/issues/show/index.js

@@ -8,7 +8,7 @@ document.addEventListener('DOMContentLoaded', () => {
   initSidebarBundle();
   initRelatedIssues();
 
-  if (gon.features.versionedDesigns) {
+  if (document.getElementById('js-design-management')) {
     import(/* webpackChunkName: 'design_management' */ 'ee/design_management')
       .then(module => module.default())
       .catch(() => {});

ee/app/controllers/ee/projects/issues_controller.rb

@@ -16,9 +16,6 @@ module EE
         before_action :check_export_issues_available!, only: [:export_csv]
         before_action :check_service_desk_available!, only: [:service_desk]
         before_action :whitelist_query_limiting_ee, only: [:update]
-        before_action only: :show do
-          push_frontend_feature_flag(:versioned_designs)
-        end
       end
 
       override :issue_except_actions

ee/app/models/license.rb

@@ -75,6 +75,7 @@ class License < ApplicationRecord
     batch_comments
     issues_analytics
     merge_pipelines
+    design_management
   ]
   EEP_FEATURES.freeze
 

ee/app/views/projects/issues/_discussion.html.haml

-- if Feature.enabled?(:versioned_designs)
+- if @project.feature_available?(:design_management, current_user) && Feature.enabled?(:design_management)
   %ul.nav-tabs.nav.nav-links{ role: 'tablist' }
     %li
       = link_to '#discussion-tab', class: 'active js-issue-tabs', id: 'discussion', role: 'tab', 'aria-controls': 'js-discussion', 'aria-selected': 'true', data: { toggle: 'tab', target: '#discussion-tab' } do