Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
39952697
Commit
39952697
authored
Nov 18, 2021
by
Maxime Orefice
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove tag limit feature flag
Changelog: added
parent
b829a07d
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
3 additions
and
29 deletions
+3
-29
config/feature_flags/development/ci_build_tags_limit.yml
config/feature_flags/development/ci_build_tags_limit.yml
+0
-8
lib/gitlab/ci/config/entry/tags.rb
lib/gitlab/ci/config/entry/tags.rb
+0
-2
spec/lib/gitlab/ci/config/entry/tags_spec.rb
spec/lib/gitlab/ci/config/entry/tags_spec.rb
+3
-19
No files found.
config/feature_flags/development/ci_build_tags_limit.yml
deleted
100644 → 0
View file @
b829a07d
---
name
:
ci_build_tags_limit
introduced_by_url
:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/68380
rollout_issue_url
:
https://gitlab.com/gitlab-org/gitlab/-/issues/338929
milestone
:
'
14.2'
type
:
development
group
:
group::pipeline execution
default_enabled
:
true
lib/gitlab/ci/config/entry/tags.rb
View file @
39952697
...
...
@@ -16,8 +16,6 @@ module Gitlab
validates
:config
,
array_of_strings:
true
validate
do
next
unless
::
Feature
.
enabled?
(
:ci_build_tags_limit
,
default_enabled: :yaml
)
if
config
.
is_a?
(
Array
)
&&
config
.
size
>=
TAGS_LIMIT
errors
.
add
(
:config
,
_
(
"must be less than the limit of %{tag_limit} tags"
)
%
{
tag_limit:
TAGS_LIMIT
})
end
...
...
spec/lib/gitlab/ci/config/entry/tags_spec.rb
View file @
39952697
...
...
@@ -36,25 +36,9 @@ RSpec.describe Gitlab::Ci::Config::Entry::Tags do
context
'when tags limit is reached'
do
let
(
:config
)
{
Array
.
new
(
50
)
{
|
i
|
"tag-
#{
i
}
"
}
}
context
'when ci_build_tags_limit is enabled'
do
before
do
stub_feature_flags
(
ci_build_tags_limit:
true
)
end
it
'reports error'
do
expect
(
entry
.
errors
)
.
to
include
"tags config must be less than the limit of
#{
described_class
::
TAGS_LIMIT
}
tags"
end
end
context
'when ci_build_tags_limit is disabled'
do
before
do
stub_feature_flags
(
ci_build_tags_limit:
false
)
end
it
'does not report an error'
do
expect
(
entry
.
errors
).
to
be_empty
end
it
'reports error'
do
expect
(
entry
.
errors
)
.
to
include
"tags config must be less than the limit of
#{
described_class
::
TAGS_LIMIT
}
tags"
end
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment