Commit 3bce3014 authored by Clement Ho's avatar Clement Ho

Merge branch 'enable-scss-lint-unnecessary-parent-reference' into 'master'

Enable UnnecessaryParentReference in scss-lint

See merge request !12738
parents 7fb7acd7 325191dd
...@@ -244,7 +244,7 @@ linters: ...@@ -244,7 +244,7 @@ linters:
# Do not use parent selector references (&) when they would otherwise # Do not use parent selector references (&) when they would otherwise
# be unnecessary. # be unnecessary.
UnnecessaryParentReference: UnnecessaryParentReference:
enabled: false enabled: true
# URLs should be valid and not contain protocols or domain names. # URLs should be valid and not contain protocols or domain names.
UrlFormat: UrlFormat:
......
...@@ -368,7 +368,7 @@ ...@@ -368,7 +368,7 @@
margin-right: 0.3em; margin-right: 0.3em;
} }
& > .value { > .value {
font-weight: 600; font-weight: 600;
} }
} }
...@@ -467,7 +467,7 @@ ...@@ -467,7 +467,7 @@
-webkit-flex-direction: column; -webkit-flex-direction: column;
flex-direction: column; flex-direction: column;
&> span { > span {
white-space: normal; white-space: normal;
word-break: break-all; word-break: break-all;
} }
......
...@@ -61,7 +61,7 @@ ...@@ -61,7 +61,7 @@
&:focus { &:focus {
outline: none; outline: none;
& i { i {
visibility: visible; visibility: visible;
} }
} }
......
...@@ -96,7 +96,7 @@ ...@@ -96,7 +96,7 @@
overflow: visible; overflow: visible;
} }
& > span { > span {
padding-right: 4px; padding-right: 4px;
} }
......
...@@ -250,7 +250,7 @@ ul.notes { ...@@ -250,7 +250,7 @@ ul.notes {
} }
.note-text { .note-text {
& p:first-child { p:first-child {
display: none; display: none;
} }
......
...@@ -96,12 +96,12 @@ ...@@ -96,12 +96,12 @@
} }
&:last-child { &:last-child {
& .pipeline-variable-row-remove-button { .pipeline-variable-row-remove-button {
display: none; display: none;
} }
@media (max-width: $screen-sm-max) { @media (max-width: $screen-sm-max) {
& .pipeline-variable-value-input { .pipeline-variable-value-input {
margin-right: $pipeline-variable-remove-button-width; margin-right: $pipeline-variable-remove-button-width;
} }
} }
......
...@@ -26,7 +26,7 @@ ...@@ -26,7 +26,7 @@
margin-bottom: 5px; margin-bottom: 5px;
} }
& > .form-group { > .form-group {
padding-left: 0; padding-left: 0;
} }
...@@ -83,7 +83,7 @@ ...@@ -83,7 +83,7 @@
border: 1px solid $border-color; border: 1px solid $border-color;
} }
& + .select2 a { + .select2 a {
border-top-left-radius: 0; border-top-left-radius: 0;
border-bottom-left-radius: 0; border-bottom-left-radius: 0;
} }
......
...@@ -81,7 +81,7 @@ ...@@ -81,7 +81,7 @@
.todo-title { .todo-title {
display: flex; display: flex;
& > .title-item { > .title-item {
-webkit-flex: 0 0 auto; -webkit-flex: 0 0 auto;
flex: 0 0 auto; flex: 0 0 auto;
margin: 0 2px; margin: 0 2px;
......
...@@ -147,13 +147,13 @@ ...@@ -147,13 +147,13 @@
} }
ul.wiki-pages-list.content-list { ul.wiki-pages-list.content-list {
& ul { ul {
list-style: none; list-style: none;
margin-left: 0; margin-left: 0;
padding-left: 15px; padding-left: 15px;
} }
& ul li { ul li {
padding: 5px 0; padding: 5px 0;
} }
} }
......
---
title: Enable UnnecessaryParentReference in scss-lint
merge_request: 12738
author: Takuya Noguchi
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment