Remove loadManagedLicensesError state property

This removes the loadManagedLicensesError property from the license management store.
This property isn't used anywhere, so it does not make sense to keep
maintaining it and the associated actions and mutations.

ee/app/assets/javascripts/vue_shared/license_compliance/store/actions.js

@@ -55,8 +55,8 @@ export const requestManagedLicenses = ({ commit }) => {
 export const receiveManagedLicensesSuccess = ({ commit }, licenses) => {
   commit(types.RECEIVE_MANAGED_LICENSES_SUCCESS, licenses);
 };
-export const receiveManagedLicensesError = ({ commit }, error) => {
-  commit(types.RECEIVE_MANAGED_LICENSES_ERROR, error);
+export const receiveManagedLicensesError = ({ commit }) => {
+  commit(types.RECEIVE_MANAGED_LICENSES_ERROR);
 };
 export const fetchManagedLicenses = ({ dispatch, state }) => {
   dispatch('requestManagedLicenses');
@@ -68,8 +68,8 @@ export const fetchManagedLicenses = ({ dispatch, state }) => {
     .then(({ data }) => {
       dispatch('receiveManagedLicensesSuccess', data);
     })
-    .catch((error) => {
-      dispatch('receiveManagedLicensesError', error);
+    .catch(() => {
+      dispatch('receiveManagedLicensesError');
     });
 };
 

ee/app/assets/javascripts/vue_shared/license_compliance/store/mutations.js

@@ -31,14 +31,12 @@ export default {
     Object.assign(state, {
       managedLicenses,
       isLoadingManagedLicenses: false,
-      loadManagedLicensesError: false,
     });
   },
-  [types.RECEIVE_MANAGED_LICENSES_ERROR](state, error) {
+  [types.RECEIVE_MANAGED_LICENSES_ERROR](state) {
     Object.assign(state, {
       managedLicenses: [],
       isLoadingManagedLicenses: false,
-      loadManagedLicensesError: error,
     });
   },
   [types.REQUEST_MANAGED_LICENSES](state) {

ee/app/assets/javascripts/vue_shared/license_compliance/store/state.js

@@ -9,7 +9,6 @@ export default () => ({
   isLoadingManagedLicenses: false,
   pendingLicenses: [],
   loadLicenseReportError: false,
-  loadManagedLicensesError: false,
   managedLicenses: [],
   newLicenses: [],
   existingLicenses: [],

ee/spec/frontend/vue_shared/license_compliance/store/actions_spec.js

@@ -414,7 +414,7 @@ describe('License store actions', () => {
         actions.receiveManagedLicensesError,
         error,
         state,
-        [{ type: mutationTypes.RECEIVE_MANAGED_LICENSES_ERROR, payload: error }],
+        [{ type: mutationTypes.RECEIVE_MANAGED_LICENSES_ERROR }],
         [],
       )
         .then(done)
@@ -452,10 +452,7 @@ describe('License store actions', () => {
         null,
         state,
         [],
-        [
-          { type: 'requestManagedLicenses' },
-          { type: 'receiveManagedLicensesError', payload: expect.any(Error) },
-        ],
+        [{ type: 'requestManagedLicenses' }, { type: 'receiveManagedLicensesError' }],
       )
         .then(done)
         .catch(done.fail);

ee/spec/frontend/vue_shared/license_compliance/store/mutations_spec.js

@@ -177,13 +177,12 @@ describe('License store mutations', () => {
   });
 
   describe('RECEIVE_MANAGED_LICENSES_SUCCESS', () => {
-    it('sets isLoadingManagedLicenses and loadManagedLicensesError to false and saves managed licenses', () => {
+    it('sets isLoadingManagedLicenses to false and saves managed licenses', () => {
       store.replaceState({
         ...store.state,
         licenseManagement: {
           managedLicenses: false,
           isLoadingManagedLicenses: true,
-          loadManagedLicensesError: true,
         },
       });
 
@@ -196,7 +195,6 @@ describe('License store mutations', () => {
       ]);
 
       expect(store.state.licenseManagement.isLoadingManagedLicenses).toBe(false);
-      expect(store.state.licenseManagement.loadManagedLicensesError).toBe(false);
     });
   });
 
@@ -207,14 +205,12 @@ describe('License store mutations', () => {
         ...store.state,
         licenseManagement: {
           isLoadingManagedLicenses: true,
-          loadManagedLicensesError: false,
         },
       });
 
       store.commit(`licenseManagement/${types.RECEIVE_MANAGED_LICENSES_ERROR}`, error);
 
       expect(store.state.licenseManagement.isLoadingManagedLicenses).toBe(false);
-      expect(store.state.licenseManagement.loadManagedLicensesError).toBe(error);
     });
   });