Merge branch '352251_remove_feature_flag' into 'master'

Use strong params for ProjectsController by default

See merge request gitlab-org/gitlab!81392

app/controllers/projects_controller.rb

@@ -345,11 +345,7 @@ class ProjectsController < Projects::ApplicationController
   private
 
   def refs_params
-    if Feature.enabled?(:strong_parameters_for_project_controller, @project, default_enabled: :yaml)
-      params.permit(:search, :sort, :ref, find: [])
-    else
-      params
-    end
+    params.permit(:search, :sort, :ref, find: [])
   end
 
   # Render project landing depending of which features are available

config/feature_flags/development/strong_parameters_for_project_controller.yml

----
-name: strong_parameters_for_project_controller
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/79956
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/352251
-milestone: '14.8'
-type: development
-group: group::source code
-default_enabled: false

spec/controllers/projects_controller_spec.rb

@@ -1211,16 +1211,6 @@ RSpec.describe ProjectsController do
 
         expect(response).to have_gitlab_http_status(:success)
       end
-
-      context 'when "strong_parameters_for_project_controller" FF is disabled' do
-        before do
-          stub_feature_flags(strong_parameters_for_project_controller: false)
-        end
-
-        it 'raises an exception' do
-          expect { request }.to raise_error(TypeError)
-        end
-      end
     end
   end