Merge branch 'handle-too-large-file-diffs-push-email' into 'master'
In emails-on-push message, indicate message that individual file diff is too large If a single file exceeded a diff limit, the previous implementation would just include the file as changed but the diff itself was not shown, leading to confusion: ![image](/uploads/18cd8e6b5c571305927097e1baf6097d/image.png) Notice how the `nodes.pp` line shows no changes. Diff overflow limits apply to different cases: 1. The entire diff exceeds 100 files OR 5000 lines 2. One single file exceeds 100 KB Example case 2: Let's say we have a diff of 50 files, most of them under 100 KB, but one of them over that limit. In this case, the idea of gitlab-org/gitlab-ce!2705 is that GitLab should show the diff of the 49 files but omit the last one. New screenshot: ![image](/uploads/9a0ac68e3deb08c28cab032fbbb80c9f/image.png) See merge request !340
Showing
Please register or sign in to comment