Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
423f3b3c
Commit
423f3b3c
authored
Feb 20, 2020
by
Sean McGivern
Committed by
Mike Lewis
Feb 20, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Prefer memory bound to CPU bound if a worker is both
parent
9dfd885b
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
6 additions
and
2 deletions
+6
-2
doc/development/sidekiq_style_guide.md
doc/development/sidekiq_style_guide.md
+6
-2
No files found.
doc/development/sidekiq_style_guide.md
View file @
423f3b3c
...
...
@@ -167,7 +167,7 @@ Most workers tend to spend most of their time blocked, wait on network responses
from other services such as Redis, Postgres and Gitaly. Since Sidekiq is a
multithreaded environment, these jobs can be scheduled with high concurrency.
Some workers, however, spend large amounts of time _on-
cpu
_ running logic in
Some workers, however, spend large amounts of time _on-
CPU
_ running logic in
Ruby. Ruby MRI does not support true multithreading - it relies on the
[
GIL
](
https://thoughtbot.com/blog/untangling-ruby-threads#the-global-interpreter-lock
)
to greatly simplify application development by only allowing one section of Ruby
...
...
@@ -187,13 +187,17 @@ performance.
Likewise, if a worker uses large amounts of memory, we can run these on a
bespoke low concurrency, high memory fleet.
Note that
M
emory-bound workers create heavy GC workloads, with pauses of
Note that
m
emory-bound workers create heavy GC workloads, with pauses of
10-50ms. This will have an impact on the latency requirements for the
worker. For this reason,
`memory`
bound,
`latency_sensitive`
jobs are not
permitted and will fail CI. In general,
`memory`
bound workers are
discouraged, and alternative approaches to processing the work should be
considered.
If a worker needs large amounts of both memory and CPU time, it should be marked as
memory-bound, due to the above restrction on latency-sensitive memory-bound
workers.
## Declaring a Job as CPU-bound
This example shows how to declare a job as being CPU-bound.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment