Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
4251a0f4
Commit
4251a0f4
authored
Apr 04, 2022
by
Kerri Miller
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove mrc_api_use_raw_diffs_from_gitaly flag
Changelog: removed
parent
96a8605e
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
2 additions
and
14 deletions
+2
-14
config/feature_flags/development/mrc_api_use_raw_diffs_from_gitaly.yml
...e_flags/development/mrc_api_use_raw_diffs_from_gitaly.yml
+0
-8
lib/api/entities/merge_request_changes.rb
lib/api/entities/merge_request_changes.rb
+1
-1
spec/requests/api/merge_requests_spec.rb
spec/requests/api/merge_requests_spec.rb
+1
-5
No files found.
config/feature_flags/development/mrc_api_use_raw_diffs_from_gitaly.yml
deleted
100644 → 0
View file @
96a8605e
---
name
:
mrc_api_use_raw_diffs_from_gitaly
introduced_by_url
:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/46190
rollout_issue_url
:
https://gitlab.com/gitlab-org/gitlab/-/issues/225322
type
:
development
group
:
group::code review
default_enabled
:
false
milestone
:
'
13.6'
lib/api/entities/merge_request_changes.rb
View file @
4251a0f4
...
...
@@ -24,7 +24,7 @@ module API
end
def
expose_raw_diffs?
options
[
:access_raw_diffs
]
||
::
Feature
.
enabled?
(
:mrc_api_use_raw_diffs_from_gitaly
,
options
[
:project
])
options
[
:access_raw_diffs
]
end
end
end
...
...
spec/requests/api/merge_requests_spec.rb
View file @
4251a0f4
...
...
@@ -1605,11 +1605,7 @@ RSpec.describe API::MergeRequests do
expect
(
json_response
[
'overflow'
]).
to
be_falsy
end
context
'when using DB-backed diffs via feature flag'
do
before
do
stub_feature_flags
(
mrc_api_use_raw_diffs_from_gitaly:
false
)
end
context
'when using DB-backed diffs'
do
it_behaves_like
'find an existing merge request'
it
'accesses diffs via DB-backed diffs.diffs'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment