Commit 4276151e authored by Brandon Labuschagne's avatar Brandon Labuschagne Committed by Paul Slaughter

Migrate fa-spinner in cycle analytics

The fa-spinner has been removed from the vue rendering haml
template.

The css related to this has been removed too.
parent 81dd2f03
import $ from 'jquery'; import $ from 'jquery';
import Vue from 'vue'; import Vue from 'vue';
import Cookies from 'js-cookie'; import Cookies from 'js-cookie';
import { GlEmptyState } from '@gitlab/ui'; import { GlEmptyState, GlLoadingIcon } from '@gitlab/ui';
import filterMixins from 'ee_else_ce/analytics/cycle_analytics/mixins/filter_mixins'; import filterMixins from 'ee_else_ce/analytics/cycle_analytics/mixins/filter_mixins';
import Flash from '../flash'; import Flash from '../flash';
import { __ } from '~/locale'; import { __ } from '~/locale';
...@@ -28,6 +28,7 @@ export default () => { ...@@ -28,6 +28,7 @@ export default () => {
name: 'CycleAnalytics', name: 'CycleAnalytics',
components: { components: {
GlEmptyState, GlEmptyState,
GlLoadingIcon,
banner, banner,
'stage-issue-component': stageComponent, 'stage-issue-component': stageComponent,
'stage-plan-component': stageComponent, 'stage-plan-component': stageComponent,
......
...@@ -109,14 +109,6 @@ ...@@ -109,14 +109,6 @@
top: $gl-padding-top; top: $gl-padding-top;
} }
.fa-spinner {
font-size: 28px;
position: relative;
margin-left: -20px;
left: 50%;
margin-top: 36px;
}
.stage-panel-body { .stage-panel-body {
display: flex; display: flex;
flex-wrap: wrap; flex-wrap: wrap;
......
...@@ -5,7 +5,7 @@ ...@@ -5,7 +5,7 @@
%banner{ "v-if" => "!isOverviewDialogDismissed", %banner{ "v-if" => "!isOverviewDialogDismissed",
"documentation-link": help_page_path('user/analytics/value_stream_analytics.md'), "documentation-link": help_page_path('user/analytics/value_stream_analytics.md'),
"v-on:dismiss-overview-dialog" => "dismissOverviewDialog()" } "v-on:dismiss-overview-dialog" => "dismissOverviewDialog()" }
= icon("spinner spin", "v-show" => "isLoading") %gl-loading-icon{ "v-show" => "isLoading", "size" => "lg" }
.wrapper{ "v-show" => "!isLoading && !hasError" } .wrapper{ "v-show" => "!isLoading && !hasError" }
.card .card
.card-header .card-header
...@@ -57,8 +57,7 @@ ...@@ -57,8 +57,7 @@
%ul %ul
%stage-nav-item{ "v-for" => "stage in state.stages", ":key" => '`ca-stage-title-${stage.title}`', '@select' => 'selectStage(stage)', ":title" => "stage.title", ":is-user-allowed" => "stage.isUserAllowed", ":value" => "stage.value", ":is-active" => "stage.active" } %stage-nav-item{ "v-for" => "stage in state.stages", ":key" => '`ca-stage-title-${stage.title}`', '@select' => 'selectStage(stage)', ":title" => "stage.title", ":is-user-allowed" => "stage.isUserAllowed", ":value" => "stage.value", ":is-active" => "stage.active" }
.section.stage-events .section.stage-events
%template{ "v-if" => "isLoadingStage" } %gl-loading-icon{ "v-show" => "isLoadingStage", "size" => "lg" }
= icon("spinner spin")
%template{ "v-if" => "currentStage && !currentStage.isUserAllowed" } %template{ "v-if" => "currentStage && !currentStage.isUserAllowed" }
= render partial: "no_access" = render partial: "no_access"
%template{ "v-else" => true } %template{ "v-else" => true }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment