Merge branch 'improve_notification_settings_query_performance' into 'master'

Add a new index to improve query performance

See merge request gitlab-org/gitlab!58895

changelogs/unreleased/improve_notification_settings_query_performance.yml

+---
+title: Adjust indices to improve query performance for notification_settings
+merge_request: 58895
+author:
+type: performance

db/post_migrate/20210402005225_add_source_and_level_index_on_notification_settings.rb

+# frozen_string_literal: true
+
+class AddSourceAndLevelIndexOnNotificationSettings < ActiveRecord::Migration[6.0]
+  include Gitlab::Database::MigrationHelpers
+
+  DOWNTIME = false
+  INDEX_WITH_SOURCE_LEVEL_USER_NAME = 'index_notification_settings_on_source_and_level_and_user'
+  INDEX_WITH_SOURCE_NAME = 'index_notification_settings_on_source_id_and_source_type'
+  INDEX_WITH_USER_NAME = 'index_notification_settings_on_user_id'
+
+  disable_ddl_transaction!
+
+  def up
+    add_concurrent_index :notification_settings, [:source_id, :source_type, :level, :user_id], name: INDEX_WITH_SOURCE_LEVEL_USER_NAME
+    remove_concurrent_index_by_name :notification_settings, INDEX_WITH_SOURCE_NAME # Above index expands this index
+    remove_concurrent_index_by_name :notification_settings, INDEX_WITH_USER_NAME # It is redundant as we already have unique index on (user_id, source_id, source_type)
+  end
+
+  def down
+    add_concurrent_index :notification_settings, [:source_id, :source_type], name: INDEX_WITH_SOURCE_NAME
+    add_concurrent_index :notification_settings, [:user_id], name: INDEX_WITH_USER_NAME
+    remove_concurrent_index_by_name :notification_settings, INDEX_WITH_SOURCE_LEVEL_USER_NAME
+  end
+end

db/schema_migrations/20210402005225

+6c44623655732e9c2916f7a71d51f53e819a216b8936d20d28d6acf37cc94fdf
\ No newline at end of file

db/structure.sql

@@ -23229,9 +23229,7 @@ CREATE INDEX index_notes_on_project_id_and_noteable_type ON notes USING btree (p
 
 CREATE INDEX index_notes_on_review_id ON notes USING btree (review_id);
 
-CREATE INDEX index_notification_settings_on_source_id_and_source_type ON notification_settings USING btree (source_id, source_type);
-
-CREATE INDEX index_notification_settings_on_user_id ON notification_settings USING btree (user_id);
+CREATE INDEX index_notification_settings_on_source_and_level_and_user ON notification_settings USING btree (source_id, source_type, level, user_id);
 
 CREATE UNIQUE INDEX index_notifications_on_user_id_and_source_id_and_source_type ON notification_settings USING btree (user_id, source_id, source_type);