Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
42cfa6a3
Commit
42cfa6a3
authored
Nov 10, 2020
by
Desiree Chevalier
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Clean up comment filter e2e spec
parent
c22d72d1
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
12 additions
and
8 deletions
+12
-8
qa/qa/page/component/note.rb
qa/qa/page/component/note.rb
+7
-1
qa/qa/specs/features/browser_ui/2_plan/issue/collapse_comments_in_discussions_spec.rb
..._ui/2_plan/issue/collapse_comments_in_discussions_spec.rb
+5
-7
No files found.
qa/qa/page/component/note.rb
View file @
42cfa6a3
...
...
@@ -122,13 +122,17 @@ module QA
def
select_all_activities_filter
select_filter_with_text
(
'Show all activity'
)
wait_until
do
has_no_element?
(
:discussion_filter_container
)
&&
has_element?
(
:comment_field
)
end
end
def
select_comments_only_filter
select_filter_with_text
(
'Show comments only'
)
wait_until
do
has_no_element?
(
:system_note_content
)
has_no_element?
(
:
discussion_filter_container
)
&&
has_no_element?
(
:
system_note_content
)
end
end
...
...
@@ -145,6 +149,8 @@ module QA
click_element
:note_dropdown
click_element
:discussion_menu_item
click_element
:comment_button
has_comment?
(
text
)
end
def
toggle_comments
(
position
)
...
...
qa/qa/specs/features/browser_ui/2_plan/issue/collapse_comments_in_discussions_spec.rb
View file @
42cfa6a3
...
...
@@ -4,22 +4,20 @@ module QA
RSpec
.
describe
'Plan'
,
:reliable
do
describe
'collapse comments in issue discussions'
do
let
(
:my_first_reply
)
{
'My first reply'
}
let
(
:one_reply
)
{
'1 reply'
}
let
(
:issue
)
{
Resource
::
Issue
.
fabricate_via_api!
}
before
do
Flow
::
Login
.
sign_in
Resource
::
Issue
.
fabricate_via_api!
.
visit!
issue
.
visit!
end
it
'collapses and expands reply for comments in an issue'
,
testcase:
'https://gitlab.com/gitlab-org/quality/testcases/-/issues/434'
do
Page
::
Project
::
Issue
::
Show
.
perform
do
|
show
|
show
.
select_all_activities_filter
show
.
start_discussion
(
'My first discussion'
)
show
.
reply_to_discussion
(
1
,
my_first_reply
)
end
end
it
'collapses and expands reply for comments in an issue'
,
testcase:
'https://gitlab.com/gitlab-org/quality/testcases/-/issues/434'
do
Page
::
Project
::
Issue
::
Show
.
perform
do
|
show
|
one_reply
=
"1 reply"
show
.
collapse_replies
expect
(
show
).
to
have_content
(
one_reply
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment