Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
431d7cd3
Commit
431d7cd3
authored
May 18, 2021
by
Sean McGivern
Committed by
Quang-Minh Nguyen
May 18, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Apply 2 suggestion(s) to 2 file(s)
parent
4bcc3573
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
3 additions
and
3 deletions
+3
-3
changelogs/unreleased/qmnguyen0711-compress-background-job-payloads.yml
...eleased/qmnguyen0711-compress-background-job-payloads.yml
+1
-1
lib/gitlab/sidekiq_middleware/size_limiter/compressor.rb
lib/gitlab/sidekiq_middleware/size_limiter/compressor.rb
+1
-1
spec/lib/gitlab/sidekiq_middleware/size_limiter/compressor_spec.rb
...gitlab/sidekiq_middleware/size_limiter/compressor_spec.rb
+1
-1
No files found.
changelogs/unreleased/qmnguyen0711-compress-background-job-payloads.yml
View file @
431d7cd3
...
...
@@ -2,4 +2,4 @@
title
:
Compress oversized Sidekiq job payload before dispatching into Redis
merge_request
:
61667
author
:
type
:
performance
type
:
added
lib/gitlab/sidekiq_middleware/size_limiter/compressor.rb
View file @
431d7cd3
...
...
@@ -41,7 +41,7 @@ module Gitlab
def
self
.
validate_args!
(
job
)
if
job
[
'args'
]
&&
job
[
'args'
].
length
!=
1
exception
=
PayloadDecompressionConflictError
.
new
(
'Sidekiq argument list should include 1 argument.\
Th
ere should be a middleware interferes
the job payload.\
Th
is means that there is another a middleware interfering with
the job payload.\
That conflicts with the payload compressor'
)
::
Gitlab
::
ErrorTracking
.
track_and_raise_exception
(
exception
)
end
...
...
spec/lib/gitlab/sidekiq_middleware/size_limiter/compressor_spec.rb
View file @
431d7cd3
...
...
@@ -91,7 +91,7 @@ RSpec.describe Gitlab::SidekiqMiddleware::SizeLimiter::Compressor do
context
'job payload is not compressed'
do
let
(
:payload
)
{
base_payload
.
merge
(
"args"
=>
[
'hello'
])
}
it
'reserves the payload after decompression'
do
it
'
p
reserves the payload after decompression'
do
original_payload
=
payload
.
deep_dup
described_class
.
decompress
(
payload
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment