Merge branch 'rails-save-bang-spec-factories' into 'master'

Fix Rails/SaveBang offenses in spec/factories_spec.rb

See merge request gitlab-org/gitlab!58102

.rubocop_manual_todo.yml

@@ -154,7 +154,6 @@ Rails/SaveBang:
     - 'spec/controllers/boards/issues_controller_spec.rb'
     - 'spec/controllers/sent_notifications_controller_spec.rb'
     - 'spec/controllers/sessions_controller_spec.rb'
-    - 'spec/factories_spec.rb'
     - 'spec/frontend/fixtures/issues.rb'
     - 'spec/frontend/fixtures/merge_requests.rb'
     - 'spec/graphql/mutations/merge_requests/set_locked_spec.rb'

changelogs/unreleased/rails-save-bang-factories.yml

+---
+title: Fix Rails/SaveBang rubocop offenses in spec/factories_spec.rb
+merge_request: 58102
+author: Abdul Wadood @abdulwd
+type: fixed

spec/factories_spec.rb

@@ -44,7 +44,7 @@ RSpec.describe 'factories' do
       end
 
       it 'does not raise error when created' do
-        expect { create(factory.name) }.not_to raise_error
+        expect { create(factory.name) }.not_to raise_error # rubocop:disable Rails/SaveBang
       end
 
       factory.definition.defined_traits.map(&:name).each do |trait_name|