simplify multi-if into single case when

44598ec5 · Mario de la Ossa · Jose Vargas · 9a65cdba · 44598ec5
Commit 44598ec5 authored Oct 11, 2018 by Mario de la Ossa Committed by Jose Vargas Dec 05, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 5 deletions

app/helpers/sorting_helper.rb app/helpers/sorting_helper.rb +2 -5

No files found.
--- a/app/helpers/sorting_helper.rb
+++ b/app/helpers/sorting_helper.rb
@@ -174,11 +174,8 @@ module SortingHelper

    link_to(reverse_url, type: 'button', class: link_class) do
      icon_suffix =
-        if sort_value == sort_value_milestone
-          'lowest'
-        elsif sort_value == sort_value_due_date
-          'lowest'
-        elsif sort_value.ends_with?('_asc')
+        case sort_value
+        when sort_value_milestone, sort_value_due_date, /_asc\z/
          'lowest'
        else
          'highest'